[PATCH] D110925: [clangd] Follow-up on rGdea48079b90d

ntfshard added a comment. Still not sure, getHashValue function returns unsigned, but seems it should return hash_code or result of operator size_t() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110925/new/ https://reviews.llvm.org/D110925 _

[PATCH] D110925: [clangd] Follow-up on rGdea48079b90d

kbobyrev marked an inline comment as done. kbobyrev added inline comments. Comment at: llvm/include/llvm/Support/FileSystem/UniqueID.h:68 +return hash_value( +std::pair(Tag.getDevice(), Tag.getFile())); + } ntfshard wrote: > In this line a narrow con

[PATCH] D110925: [clangd] Follow-up on rGdea48079b90d

ntfshard added a comment. It seems I faced with degradation in compile time. Comment at: llvm/include/llvm/Support/FileSystem/UniqueID.h:68 +return hash_value( +std::pair(Tag.getDevice(), Tag.getFile())); + } In this line a narrow conversion, and M

[PATCH] D110925: [clangd] Follow-up on rGdea48079b90d

sammccall added a comment. In D110925#3041807 , @kbobyrev wrote: > Ahh, sorry, I thought you meant the other one :( Apologies for confusion All good. Instead of relying on us to spot this stuff, we should probably build some tooling to tell us which inc

Re: [PATCH] D110925: [clangd] Follow-up on rGdea48079b90d

Ahh, sorry, I thought you meant the other one :( Apologies for confusion On Tue, Oct 5, 2021 at 9:58 AM Sam McCall via Phabricator < revi...@reviews.llvm.org> wrote: > sammccall added inline comments. > > > > Comment at: llvm/include/llvm/Support/FileSystem/UniqueID.h:17 > > +#in

[PATCH] D110925: [clangd] Follow-up on rGdea48079b90d

sammccall added inline comments. Comment at: llvm/include/llvm/Support/FileSystem/UniqueID.h:17 +#include "llvm/ADT/DenseMap.h" #include kbobyrev wrote: > sammccall wrote: > > you only need DenseMapInfo here > I think I do need utility because I'm using `std:

[PATCH] D110925: [clangd] Follow-up on rGdea48079b90d

This revision was automatically updated to reflect the committed changes. Closed by commit rGb06df223826e: [clangd] Follow-up on rGdea48079b90d (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110925/new/ https://reviews.llvm.or

[PATCH] D110925: [clangd] Follow-up on rGdea48079b90d

kbobyrev added inline comments. Comment at: llvm/include/llvm/Support/FileSystem/UniqueID.h:17 +#include "llvm/ADT/DenseMap.h" #include sammccall wrote: > you only need DenseMapInfo here I think I do need utility because I'm using `std::pair` Repository:

[PATCH] D110925: [clangd] Follow-up on rGdea48079b90d

kbobyrev updated this revision to Diff 376811. kbobyrev marked 9 inline comments as done. kbobyrev added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110925/new/ https://reviews.llvm.org/D110925 Files: clang-

[PATCH] D110925: [clangd] Follow-up on rGdea48079b90d

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! Just nits (This review addresses comments on https://reviews.llvm.org/rGdea48079b90d40f2087435b778544dffb0ab1793) Comment at: clang-tools-extra/clangd/Headers

[PATCH] D110925: [clangd] Follow-up on rGdea48079b90d

kbobyrev updated this revision to Diff 376488. kbobyrev added a comment. Get rid of SM in getOrCreateID & getID Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110925/new/ https://reviews.llvm.org/D110925 Files: clang-tools-extra/clangd/CodeComple

[PATCH] D110925: [clangd] Follow-up on rGdea48079b90d

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: dexonsmith, usaxena95, kadircet, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, llvm-commits, MaskRay, ilya-biryukov. Herald added projects: LLVM, clang-tool