[PATCH] D110910: [analyzer][solver] Fix CmpOpTable handling bug

2021-10-06 Thread Denys Petrov via Phabricator via cfe-commits
ASDenysPetrov added a comment. LGTM Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1129-1134 +// We use this variable to store the last queried operator (`QueriedOP`) +// for which the `getCmpOpState` returned with `Unknown`. If there are two +

[PATCH] D110910: [analyzer][solver] Fix CmpOpTable handling bug

2021-10-06 Thread Gabor Marton via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG792be5df92e8: [analyzer][solver] Fix CmpOpTable handling bug (authored by martong). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D110910: [analyzer][solver] Fix CmpOpTable handling bug

2021-10-06 Thread Gabor Marton via Phabricator via cfe-commits
martong added a comment. Thanks for the review Denys! I've updated accordingly to your suggestion, it is certainly more efficient. However, I've found your solution more difficult to follow, thus I've added some more explanatory comments. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D110910: [analyzer][solver] Fix CmpOpTable handling bug

2021-10-06 Thread Gabor Marton via Phabricator via cfe-commits
martong updated this revision to Diff 377564. martong added a comment. - Update to use a single variable to track the state - Make CurrentOP `const` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110910/new/ https://reviews.llvm.org/D110910 Files:

[PATCH] D110910: [analyzer][solver] Fix CmpOpTable handling bug

2021-10-06 Thread Denys Petrov via Phabricator via cfe-commits
ASDenysPetrov accepted this revision. ASDenysPetrov added a comment. This revision is now accepted and ready to land. I see the problem. It appears when you meet, say, '>' in a //true// branch and '<=' in a //false// branch which then turns into `>` again and trigger the flag, but shouldn't. You

[PATCH] D110910: [analyzer][solver] Fix CmpOpTable handling bug

2021-10-05 Thread Denys Petrov via Phabricator via cfe-commits
ASDenysPetrov added a comment. Thanks for mentioning me. I'll make a review of this tomorrow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110910/new/ https://reviews.llvm.org/D110910 ___ cfe-commits ma

[PATCH] D110910: [analyzer][solver] Fix CmpOpTable handling bug

2021-10-04 Thread Gabor Marton via Phabricator via cfe-commits
martong added a comment. @ASDenysPetrov Gentle ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110910/new/ https://reviews.llvm.org/D110910 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D110910: [analyzer][solver] Fix CmpOpTable handling bug

2021-10-01 Thread Gabor Marton via Phabricator via cfe-commits
martong created this revision. martong added reviewers: ASDenysPetrov, steakhal, manas, vsavchenko, NoQ. Herald added subscribers: gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald added a reviewer: Szelethus.