This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGb7ac68d01ef9: [clang][ASTImporter] Simplify code of
attribute import [NFC]. (authored by balazske).
Repository:
rG LLVM Github Monorepo
CHANGES S
steakhal accepted this revision.
steakhal added a comment.
I think it looks great.
Thank you for addressing this.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D110810/new/
https://reviews.llvm.org/D110810
__
balazske updated this revision to Diff 377143.
balazske added a comment.
Adding `&&` and new asserts to use `AttrImporter` only once.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D110810/new/
https://reviews.llvm.org/D110810
Files:
clang/lib/AST
aaron.ballman added inline comments.
Comment at: clang/lib/AST/ASTImporter.cpp:8530-8531
+ // Get the result of the previous import attempt (can be used only once).
+ llvm::Expected getResult() {
+if (Err)
steakhal wrote:
> aaron.ballman wrote:
> > steakh
steakhal added inline comments.
Comment at: clang/lib/AST/ASTImporter.cpp:8530-8531
+ // Get the result of the previous import attempt (can be used only once).
+ llvm::Expected getResult() {
+if (Err)
aaron.ballman wrote:
> steakhal wrote:
> > If it can b
aaron.ballman added inline comments.
Comment at: clang/lib/AST/ASTImporter.cpp:8530-8531
+ // Get the result of the previous import attempt (can be used only once).
+ llvm::Expected getResult() {
+if (Err)
steakhal wrote:
> If it can be used only once, we
steakhal added a subscriber: aaron.ballman.
steakhal added inline comments.
Comment at: clang/lib/AST/ASTImporter.cpp:8530-8531
+ // Get the result of the previous import attempt (can be used only once).
+ llvm::Expected getResult() {
+if (Err)
If it can
balazske updated this revision to Diff 376443.
balazske marked an inline comment as done.
balazske added a comment.
Update the code comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D110810/new/
https://reviews.llvm.org/D110810
Files:
clang
balazske updated this revision to Diff 376441.
balazske added a comment.
AttrImporter owns now the result of import (until it is read),
instead of referenced error and returned pointer.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D110810/new/
http
shafik added inline comments.
Comment at: clang/lib/AST/ASTImporter.cpp:8456
class AttrImporter {
- Error Err = Error::success();
+ Error &Err;
ASTImporter &Importer;
I am enthusiastic about reference members if we can somehow avoid them.
Can we use a stru
martong accepted this revision.
martong added a comment.
This revision is now accepted and ready to land.
Awesome! Thanks!
Please indicate in the title that this is an [NFC].
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D110810/new/
https://review
balazske created this revision.
Herald added subscribers: steakhal, whisperity, martong, teemperor, gamesh411,
Szelethus, dkrupp.
Herald added a reviewer: a.sidorin.
Herald added a reviewer: shafik.
balazske requested review of this revision.
Herald added a project: clang.
Herald added a subscribe
12 matches
Mail list logo
