[PATCH] D110781: [CUDA] Make sure is included with original __THROW defined.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG29e00b29f76a: [CUDA] Make sure is included with original __THROW defined. (authored by tra). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D110781: [CUDA] Make sure is included with original __THROW defined.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG. Always including string (probably) won't hurt given the stuff we do here already. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110781

[PATCH] D110781: [CUDA] Make sure is included with original __THROW defined.

tra added a comment. In D110781#3045280 , @jdoerfert wrote: > I first had to read up on pop_macro -.-. Still unsure if it is OK to push it > once and pop it twice, that works fine? Good catch. > Can't we move the string include earlier, grouped with st

[PATCH] D110781: [CUDA] Make sure is included with original __THROW defined.

tra updated this revision to Diff 377593. tra added a comment. Moved string.h inclusion to the top of the file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110781/new/ https://reviews.llvm.org/D110781 Files: clang/lib/Headers/__clang_cuda_runt

[PATCH] D110781: [CUDA] Make sure is included with original __THROW defined.

tra updated this revision to Diff 377587. tra added a comment. re-set __THROW to an empty value. It's still needed for CUDA-7.5 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110781/new/ https://reviews.llvm.org/D110781 Files: clang/lib/Headers/_

[PATCH] D110781: [CUDA] Make sure is included with original __THROW defined.

tra updated this revision to Diff 377573. tra edited the summary of this revision. tra added a comment. Added a missing push_macro Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110781/new/ https://reviews.llvm.org/D110781 Files: clang/lib/Header

[PATCH] D110781: [CUDA] Make sure is included with original __THROW defined.

jdoerfert added a comment. I first had to read up on pop_macro -.-. Still unsure if it is OK to push it once and pop it twice, that works fine? Can't we move the string include earlier, grouped with stdlib and cmath? then we don't need to play with __THROW twice. Other than that it seems sensibl

[PATCH] D110781: [CUDA] Make sure is included with original __THROW defined.

tra added a comment. @jdoerfert: Ping. I think you're the best match for reviewing the code related to interaction between CUDA and the system include files, even if this particular header does not have much to do with OpenMP. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D110781: [CUDA] Make sure is included with original __THROW defined.

tra created this revision. tra added a reviewer: jdoerfert. Herald added subscribers: bixia, yaxunl. tra requested review of this revision. Herald added a project: clang. Otherwise we may end up with an inconsistent redeclarations of the standard library functions if _FORTIFY_SOURCE is in effect.