[PATCH] D110742: [OpenCL] Add pure attributes to vload builtins

2021-12-16 Thread Stuart Brady via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGceb80557e523: [OpenCL] Add pure attribute to vload builtins (authored by stuart). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D110742: [OpenCL] Add pure attributes to vload builtins

2021-12-16 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. Thanks! Bots look happy again :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110742/new/ https://reviews.llvm.org/D110742 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[PATCH] D110742: [OpenCL] Add pure attributes to vload builtins

2021-12-16 Thread Stuart Brady via Phabricator via cfe-commits
stuart updated this revision to Diff 394878. stuart added a comment. I've updated the review to include test changes that are required for check-clang-semaopencl to pass. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110742/new/ https://reviews.llvm.org/D110742 Files: clang/lib/Head

[PATCH] D110742: [OpenCL] Add pure attributes to vload builtins

2021-12-16 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. looks like this broke tests: http://45.33.8.238/linux/63308/step_7.txt Please take a look, and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110742/new/ https://reviews.llvm.org/D1

[PATCH] D110742: [OpenCL] Add pure attributes to vload builtins

2021-12-16 Thread Stuart Brady via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1a376bc28535: [OpenCL] Add pure attribute to vload builtins (authored by stuart). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D110742: [OpenCL] Add pure attributes to vload builtins

2021-12-16 Thread Sven van Haastregt via Phabricator via cfe-commits
svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. In D110742#3197183 , @stuart wrote: > Thanks! I have updated the review to use `__attribute__((pure))` only (i.e. > it no longer uses `__attribute__(

[PATCH] D110742: [OpenCL] Add pure attributes to vload builtins

2021-12-16 Thread Stuart Brady via Phabricator via cfe-commits
stuart added a comment. In D110742#3194608 , @svenvh wrote: > Apologies for the late reply... I'd prefer to get the langref updated first, > for the sake of consistency and to ensure other stakeholders agree with the > interpretation. You can still go

[PATCH] D110742: [OpenCL] Add pure attributes to vload builtins

2021-12-15 Thread Stuart Brady via Phabricator via cfe-commits
stuart updated this revision to Diff 394580. stuart retitled this revision from "[OpenCL] Add pure and const attributes to vload builtins" to "[OpenCL] Add pure attributes to vload builtins". stuart edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT