[PATCH] D110742: [OpenCL] Add pure and const attributes to vload builtins

2021-12-15 Thread Sven van Haastregt via Phabricator via cfe-commits
svenvh added a comment. > Does the langref need to be amended, first, or is it okay to interpret the > `readnone` attribute as it was clearly intended, without going through the > process of updating the langref first? > > I can update this review to use `__attribute__((pure))` for all address

[PATCH] D110742: [OpenCL] Add pure and const attributes to vload builtins

2021-10-08 Thread Stuart Brady via Phabricator via cfe-commits
stuart added a comment. In D110742#3048301 , @svenvh wrote: >> For the constant address space, the const attribute (or readnone) can be >> used. As memory in the constant address space is immutable, the statement in >> the langref that: "if a readnone f

[PATCH] D110742: [OpenCL] Add pure and const attributes to vload builtins

2021-10-07 Thread Sven van Haastregt via Phabricator via cfe-commits
svenvh added a comment. > For the constant address space, the const attribute (or readnone) can be > used. As memory in the constant address space is immutable, the statement in > the langref that: "if a readnone function reads or writes memory visible to > the program, or has other side-effect

[PATCH] D110742: [OpenCL] Add pure and const attributes to vload builtins

2021-09-29 Thread Stuart Brady via Phabricator via cfe-commits
stuart created this revision. stuart added reviewers: svenvh, Anastasia, airlied, yaxunl. Herald added a subscriber: ldrumm. stuart requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Use the `pure` and `const` attributes for the `vload`, `vloa