[PATCH] D110684: [RISCV] Define _m intrinsics as builtins, instead of macros.

2021-10-12 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai added a comment. We are working on a patch, D111617 , to reduce the large header size caused by abundant RISC-V vector intrinsics. From the measurement depicted in D103228 , it should be helpful for compile time. Rep

[PATCH] D110684: [RISCV] Define _m intrinsics as builtins, instead of macros.

2021-10-12 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. This has been the first time RISC-V added something and caused performance/memory/test execution regression for other users. The problem should be considered seriously (I don't even mind reverting the patch.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D110684: [RISCV] Define _m intrinsics as builtins, instead of macros.

2021-10-12 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added a comment. In D110684#3059698 , @aeubanks wrote: > In D110684#3057498 , @nikic wrote: > >> I noticed this a few time in the past already, but this is the worst one yet: >> >> Compile-time: >> h

[PATCH] D110684: [RISCV] Define _m intrinsics as builtins, instead of macros.

2021-10-12 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks added a comment. In D110684#3057498 , @nikic wrote: > I noticed this a few time in the past already, but this is the worst one yet: > > Compile-time: > https://llvm-compile-time-tracker.com/compare.php?from=6641d29b70993bce6dbd7e0e0f1040753d3884

[PATCH] D110684: [RISCV] Define _m intrinsics as builtins, instead of macros.

2021-10-12 Thread Nikita Popov via Phabricator via cfe-commits
nikic added a comment. I noticed this a few time in the past already, but this is the worst one yet: Compile-time: https://llvm-compile-time-tracker.com/compare.php?from=6641d29b70993bce6dbd7e0e0f1040753d38842f&to=97f0c63783f52389bd8842df205379ceade7a89d&stat=instructions Max-rss: https://llvm-

[PATCH] D110684: [RISCV] Define _m intrinsics as builtins, instead of macros.

2021-10-11 Thread Hsiangkai Wang via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG97f0c63783f5: [RISCV] Define _m intrinsics as builtins, instead of macros. (authored by HsiangKai). Changed prior to commit: https://reviews.llvm.org/D110684?vs=376890&id=378859#toc Repository: rG LL

[PATCH] D110684: [RISCV] Define _m intrinsics as builtins, instead of macros.

2021-10-11 Thread Craig Topper via Phabricator via cfe-commits
craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110684/new/ https://reviews.llvm.org/D110684 ___

[PATCH] D110684: [RISCV] Define _m intrinsics as builtins, instead of macros.

2021-10-11 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added a comment. This patch was uploaded without full context. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110684/new/ https://reviews.llvm.org/D110684 ___ cfe-commits mailing list cfe-com

[PATCH] D110684: [RISCV] Define _m intrinsics as builtins, instead of macros.

2021-10-10 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110684/new/ https://reviews.llvm.org/D110684 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D110684: [RISCV] Define _m intrinsics as builtins, instead of macros.

2021-10-04 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai updated this revision to Diff 376890. HsiangKai added a comment. Update test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110684/new/ https://reviews.llvm.org/D110684 Files: clang/include/clang/Basic/IdentifierTable.h clang/i

[PATCH] D110684: [RISCV] Define _m intrinsics as builtins, instead of macros.

2021-09-29 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai created this revision. HsiangKai added reviewers: craig.topper, rogfer01, frasercrmck. Herald added subscribers: achieveartificialintelligence, StephenFan, vkmr, dexonsmith, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, Ma