[PATCH] D110673: [clang] Don't modify OptRemark if the argument is not relevant

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG76902079e429: [clang] Don't modify OptRemark if the argument is not relevant (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D110673: [clang] Don't modify OptRemark if the argument is not relevant

JamesNagurne added a comment. You're welcome! Surprising that no downstream clang was running with the old PM and assertions... I guess we better get on the new PM soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110673/new/ https://reviews.ll

[PATCH] D110673: [clang] Don't modify OptRemark if the argument is not relevant

aeubanks added a comment. Thanks for investigating! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110673/new/ https://reviews.llvm.org/D110673 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D110673: [clang] Don't modify OptRemark if the argument is not relevant

aeubanks updated this revision to Diff 376034. aeubanks added a comment. forcing the legacy PM plus -round-trip-args repros the issue. added a new PM equivalent RUN line (that does fail without this patch) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D110673: [clang] Don't modify OptRemark if the argument is not relevant

JamesNagurne added a comment. Perhaps you could reproduce my error -round-trip-args on the -cc1 command line? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110673/new/ https://reviews.llvm.org/D110673 __

[PATCH] D110673: [clang] Don't modify OptRemark if the argument is not relevant

JamesNagurne added a comment. The trigger for the remark I'm seeing is llvm::shouldInline in InlineAdvisor.cpp ((https://github.com/llvm/llvm-project/blob/2240deb9766cc080b351016b0d7f975d7249b113/llvm/lib/Transforms/IPO/Inliner.cpp#L425) which is called in a top-level AlwaysInlinerLegacyPass C

[PATCH] D110673: [clang] Don't modify OptRemark if the argument is not relevant

aeubanks added a comment. In D110673#3029438 , @JamesNagurne wrote: > I'll take a quick look tomorrow, but the general idea is that on calling > ParseOptimizationRemark on line 1909 with a -cc1 command line containing > -Rpass=inline -Rno-pass, Opts.Op

[PATCH] D110673: [clang] Don't modify OptRemark if the argument is not relevant

JamesNagurne added a comment. I'll take a quick look tomorrow, but the general idea is that on calling ParseOptimizationRemark on line 1909 with a -cc1 command line containing -Rpass=inline -Rno-pass, Opts.OptimizationRemarkMissed and Opts.OptimizationRemarkAnalysis are set to valid patterns (R

[PATCH] D110673: [clang] Don't modify OptRemark if the argument is not relevant

aeubanks added a comment. In D110673#3029253 , @dblaikie wrote: > It'd be good to understand/document (maybe document in the form of a test if > possible) how downstream users are relying on this - perhaps it's not a valid > reliance and we shouldn't ma

[PATCH] D110673: [clang] Don't modify OptRemark if the argument is not relevant

dblaikie added a comment. It'd be good to understand/document (maybe document in the form of a test if possible) how downstream users are relying on this - perhaps it's not a valid reliance and we shouldn't maintain compatibility? Maybe it is and we should ensure some test coverage of the sort

[PATCH] D110673: [clang] Don't modify OptRemark if the argument is not relevant

aeubanks created this revision. aeubanks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. A followup to D110201 . For example, we'd set OptimizationRemarkMissed's Regex to '.*' when encountering -Rpass. Th