[PATCH] D110528: [clang][ASTImporter] Add import of thread safety attributes.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbcefea80a40e: [clang][ASTImporter] Add import of thread safety attributes. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D110528: [clang][ASTImporter] Add import of thread safety attributes.

martong added a comment. In D110528#3026921 , @balazske wrote: > If the `ASTImporter` and parts of `ASTNodeImporter` are made public API then > it can be possible to add generation of import code to the **.td** files, > this should be the best solution.

[PATCH] D110528: [clang][ASTImporter] Add import of thread safety attributes.

balazske added a comment. If the `ASTImporter` and parts of `ASTNodeImporter` are made public API then it can be possible to add generation of import code to the **.td** files, this should be the best solution. In similar way, import of `Stmt` and `Expr` nodes can be generated if possible. Thes

[PATCH] D110528: [clang][ASTImporter] Add import of thread safety attributes.

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. I agree with @steakhal , that perhaps we could come up with a somewhat more compact and elegant implementation in the future. Nevertheless, I think this patch in its current form is already

[PATCH] D110528: [clang][ASTImporter] Add import of thread safety attributes.

balazske added a comment. The code can be made better in a way that only lines similar to Expected ToAttrOrErr = AI.createImportedAttr( From, AI.importArg(From->getSuccessValue()).value(), AI.importArrayArg(From->args(), From->args_size()).value(), From->args_size()); are nee

[PATCH] D110528: [clang][ASTImporter] Add import of thread safety attributes.

steakhal added a comment. I appreciate the effort in working on the attribute imports. Personally, I don't really like this change. IMO `AttrImporter::createImportedAttr()` should do the magic, and apply the necessary glue for the import. Or we could even create a dedicated function, which woul

[PATCH] D110528: [clang][ASTImporter] Add import of thread safety attributes.

balazske created this revision. Herald added subscribers: steakhal, whisperity, martong, teemperor, gamesh411, Szelethus, dkrupp. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. balazske requested review of this revision. Herald added a project: clang. Herald added a subscribe