[PATCH] D110493: [clang-tidy] Fix bug in readability-uppercase-literal-suffix

carlosgalvezp added a comment. Thanks for the clarification, makes sense! I got the notification about the build failure, thanks for fixing. I actually added it in the first place but then noticed that checkers typically didn't include any STL header so I thought maybe there was a restriction o

[PATCH] D110493: [clang-tidy] Fix bug in readability-uppercase-literal-suffix

aaron.ballman added a comment. In D110493#3025394 , @carlosgalvezp wrote: > Super, thanks! It went really smooth :) > > Newbie question: I noticed that `[clang-tidy]` is no longer part of the > commit message, I thought the intention was to keep it to m

[PATCH] D110493: [clang-tidy] Fix bug in readability-uppercase-literal-suffix

carlosgalvezp added a comment. Super, thanks! It went really smooth :) Newbye question: I noticed that `[clang-tidy]` is no longer part of the commit message, I thought the intention was to keep it to more easily glance through the commit history? CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D110493: [clang-tidy] Fix bug in readability-uppercase-literal-suffix

aaron.ballman closed this revision. aaron.ballman added a comment. In D110493#3025343 , @carlosgalvezp wrote: > Awesome, thanks a lot for the review! :) Sure, you can use the following to > commit on my behalf, since I don't think I have such permission

[PATCH] D110493: [clang-tidy] Fix bug in readability-uppercase-literal-suffix

carlosgalvezp added a comment. Awesome, thanks a lot for the review! :) Sure, you can use the following to commit on my behalf, since I don't think I have such permissions: Carlos Galvez carlosgalv...@gmail.com CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110493/new/ https://reviews.

[PATCH] D110493: [clang-tidy] Fix bug in readability-uppercase-literal-suffix

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! Would you like me to commit on your behalf? If so, please let me know what name and email address you'd like me to use for patch attribution in git. CHANGES SI