v.g.vassilev added inline comments.
Comment at: clang/include/clang/Frontend/CompilerInstance.h:223
+ void LoadRequestedPlugins();
+
/// }
sgraenitz wrote:
> This could have a minimal doxygen comment now that it's part of the public
> interface.
I somewhat h
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG81fb640f83b6: [clang-repl] Allow loading of plugins in
clang-repl.
v.g.vassilev updated this revision to Diff 377026.
v.g.vassilev marked 2 inline comments as done.
v.g.vassilev added a comment.
Address comments.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D110484/new/
https://reviews.llvm.org/D110484
Files:
clang/include/clang/Frontend/CompilerIns
rsmith added a comment.
LGTM modulo existing comments.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D110484/new/
https://reviews.llvm.org/D110484
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/l
sgraenitz added a comment.
Two minor comments. Otherwise LGTM.
Comment at: clang/include/clang/Frontend/CompilerInstance.h:223
+ void LoadRequestedPlugins();
+
/// }
This could have a minimal doxygen comment now that it's part of the public
interface.
==
v.g.vassilev updated this revision to Diff 375050.
v.g.vassilev added a comment.
add forgotten test file
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D110484/new/
https://reviews.llvm.org/D110484
Files:
clang/include/clang/Frontend/CompilerInstance.h
clang/lib/Frontend/CompilerInst
v.g.vassilev created this revision.
v.g.vassilev added reviewers: rsmith, teemperor, sgraenitz, john.brawn, klimek,
bkramer.
Herald added a subscriber: mgorny.
v.g.vassilev requested review of this revision.
https://reviews.llvm.org/D110484
Files:
clang/include/clang/Frontend/CompilerInstance.
