[PATCH] D110481: fixes bug #51926 where dangling comma caused overrun

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa36227cb2b6a: fixes bug #51926 where dangling comma caused overrun (authored by feg208). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D110481: fixes bug #51926 where dangling comma caused overrun

feg208 added a comment. Absolutely in agreement Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110481/new/ https://reviews.llvm.org/D110481 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D110481: fixes bug #51926 where dangling comma caused overrun

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. In D110481#3027289 , @feg208 wrote: > By one other bug I mean an entirely separate bug that I will handle in a > separate PR.

[PATCH] D110481: fixes bug #51926 where dangling comma caused overrun

feg208 added a comment. By one other bug I mean an entirely separate bug that I will handle in a separate PR. Sorry if that was confusing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110481/new/ https://reviews.llvm.org/D110481

[PATCH] D110481: fixes bug #51926 where dangling comma caused overrun

feg208 added a comment. So I added in the second case but commented it out as it gets misformatted. However it doesn't assert which was the alarming outcome. I have one other bug to clean up here and I am going to open a bug to fix the line breaking after initial { in certain cases since the co

[PATCH] D110481: fixes bug #51926 where dangling comma caused overrun

feg208 updated this revision to Diff 375544. feg208 added a comment. Gets rid of the crash for the second added case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110481/new/ https://reviews.llvm.org/D110481 Files: clang/lib/Format/WhitespaceMan

[PATCH] D110481: fixes bug #51926 where dangling comma caused overrun

feg208 added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:17805 + "Section{\n" + "0, bar(),\n" + "}\n" HazardyKnusperkeks wrote: > feg208 wrote: > > HazardyKnusperkeks wro

[PATCH] D110481: fixes bug #51926 where dangling comma caused overrun

HazardyKnusperkeks added a subscriber: tstellar. HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:17805 + "Section{\n" + "0, bar(),\n" + "}\n" feg208

[PATCH] D110481: fixes bug #51926 where dangling comma caused overrun

feg208 added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:17805 + "Section{\n" + "0, bar(),\n" + "}\n" HazardyKnusperkeks wrote: > feg208 wrote: > > HazardyKnusperkeks wro

[PATCH] D110481: fixes bug #51926 where dangling comma caused overrun

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:17805 + "Section{\n" + "0, bar(),\n" + "}\n" feg208 wrote: > HazardyKnusperkeks wrote: > > Here is no

[PATCH] D110481: fixes bug #51926 where dangling comma caused overrun

feg208 added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:17805 + "Section{\n" + "0, bar(),\n" + "}\n" HazardyKnusperkeks wrote: > Here is no alignment, maybe add another

[PATCH] D110481: fixes bug #51926 where dangling comma caused overrun

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:17805 + "Section{\n" + "0, bar(),\n" + "}\n" Here is no alignment, maybe add another case with anothe

[PATCH] D110481: fixes bug #51926 where dangling comma caused overrun

feg208 created this revision. feg208 added reviewers: HazardyKnusperkeks, MyDeveloperDay, curdeius, klimek, djasper, tinloaf. feg208 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. bug 51926 identified an issue where a dangling comma cause