This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG63bb2d585e97: [clang] Put original flags on 'Driver
args:' crash report line (authored by thakis).
Herald added a project: clang.
Repository:
rG L
thakis updated this revision to Diff 375232.
thakis added a comment.
add comment
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D110458/new/
https://reviews.llvm.org/D110458
Files:
clang/lib/Driver/Driver.cpp
clang/test/Driver/crash-report-clang-cl.c
Index: clang/test/Driver/crash-
thakis marked an inline comment as done.
thakis added a comment.
Thanks!
Comment at: clang/test/Driver/crash-report-clang-cl.c:2
+// RUN: rm -rf %t
+// RUN: mkdir %t
+
hans wrote:
> These always make me thing the test should "requires: shell", but I think for
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
lgtm
Comment at: clang/lib/Driver/Driver.cpp:1220
+ for (const auto *A : Args) {
+while (A->getAlias())
+ A = A->getAlias();
Could put a comment here a
thakis created this revision.
thakis added a reviewer: hans.
thakis requested review of this revision.
We used to put the canonical spelling of flags after alias processing
on that line. For clang-cl in particular, that meant that we put flags
on that line that the clang-cl driver doesn't even acc
