[PATCH] D110451: [IR] Increase max alignment to 4GB

2021-10-08 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks added a comment. Sorry about that, should be fixed with 20a0c482e0 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110451/new/ https://reviews.llvm.org/D110451

[PATCH] D110451: [IR] Increase max alignment to 4GB

2021-10-08 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan added a comment. Finally got the stacktrace: leonardchan@cp-snakewater:~/llvm-monorepo/llvm-build-1-clang-only-debug$ bin/clang++ "-cc1" "-triple" "x86_64-unknown-linux-gnu" "-emit-obj" "--mrelax-relocations" "-disable-free" "-main-file-name" "AArch64SpeculationHardening.cpp" "-m

[PATCH] D110451: [IR] Increase max alignment to 4GB

2021-10-08 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks added a comment. I've comitted https://reviews.llvm.org/rGa0a493518245fa20fe15703a1be6babcb0c43c0a, if your stack trace is different, the fix will probably be very similar Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110451/new/ https:/

[PATCH] D110451: [IR] Increase max alignment to 4GB

2021-10-08 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks added a comment. Yes a stack trace/repro would be nice. I see a couple places that might be causing issues, I'll try fixing those. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110451/new/ https://reviews.llvm.org/D110451

[PATCH] D110451: [IR] Increase max alignment to 4GB

2021-10-08 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan added a comment. Hi. It seems the reland caused an assertion to fail on our clang builders (https://luci-milo.appspot.com/ui/p/fuchsia/builders/prod/clang-linux-x64/b8834065059600721665/overview): [194/194] Building CXX object lib/Target/AArch64/CMakeFiles/LLVMAArch64CodeGen.dir/A

[PATCH] D110451: [IR] Increase max alignment to 4GB

2021-10-06 Thread Arthur Eubanks via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG05392466f02b: Reland [IR] Increase max alignment to 4GB (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D110451: [IR] Increase max alignment to 4GB

2021-10-06 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:179 -static const unsigned kAllocaRzSize = 32; +static const uint64_t kAllocaRzSize = 32; MaskRay wrote: > You may switch to namespace scope/global `constexpr

[PATCH] D110451: [IR] Increase max alignment to 4GB

2021-10-06 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:179 -static const unsigned kAllocaRzSize = 32; +static const uint64_t kAllocaRzSize = 32; You may switch to namespace scope/global `constexpr` while touching t

[PATCH] D110451: [IR] Increase max alignment to 4GB

2021-10-06 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks updated this revision to Diff 377633. aeubanks added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110451/new/ https://reviews.llvm.org/D110451 Files: clang/lib/CodeGen/CGBlocks.cpp clang/lib/CodeGen/CGCall.cpp cla

[PATCH] D110451: [IR] Increase max alignment to 4GB

2021-10-06 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks updated this revision to Diff 377631. aeubanks added a comment. more types changed throughout the codebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110451/new/ https://reviews.llvm.org/D110451 Files: clang/lib/CodeGen/CGBlocks.cpp

[PATCH] D110451: [IR] Increase max alignment to 4GB

2021-10-06 Thread Arthur Eubanks via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdf84c1fe7813: [IR] Increase max alignment to 4GB (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D110451: [IR] Increase max alignment to 4GB

2021-10-05 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks updated this revision to Diff 377335. aeubanks added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. update some clang uses to fix errors/warnings Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110451/new/