[PATCH] D110436: Add %n format specifier warning to clang-tidy

2021-10-21 Thread Jayson Yan via Phabricator via cfe-commits
Jaysonyan added inline comments. Herald added a subscriber: carlosgalvezp. Comment at: clang-tools-extra/clang-tidy/bugprone/PercentNFormatSpecifierCheck.cpp:89 +Result.Context->getTargetInfo()); +diag(loc, "usage of %%n can lead to unsafe writing to memory"); + } -

[PATCH] D110436: Add %n format specifier warning to clang-tidy

2021-10-21 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/PercentNFormatSpecifierCheck.cpp:43-57 + auto PrintfDecl = functionDecl(hasName("::printf")); + auto FprintfDecl = functionDecl(hasName("::fprintf")); + auto VfprintfDecl = functionDecl(has

[PATCH] D110436: Add %n format specifier warning to clang-tidy

2021-10-21 Thread Jayson Yan via Phabricator via cfe-commits
Jaysonyan added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/PercentNFormatSpecifierCheck.cpp:43-57 + auto PrintfDecl = functionDecl(hasName("::printf")); + auto FprintfDecl = functionDecl(hasName("::fprintf")); + auto VfprintfDecl = functionDecl(hasName

[PATCH] D110436: Add %n format specifier warning to clang-tidy

2021-10-21 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/PercentNFormatSpecifierCheck.cpp:26-27 + bool HandlePrintfSpecifier(const analyze_printf::PrintfSpecifier &FS, + const char *startSpecifier, +

[PATCH] D110436: Add %n format specifier warning to clang-tidy

2021-10-20 Thread Jayson Yan via Phabricator via cfe-commits
Jaysonyan updated this revision to Diff 381103. Jaysonyan retitled this revision from "Add %n format specifier warning" to "Add %n format specifier warning to clang-tidy". Jaysonyan added a comment. Herald added a subscriber: mgorny. Herald added a project: clang-tools-extra. Move check for `%n`