RE: [PATCH] D110429: [OpenMP] Introduce a new worksharing RTL function for distribute

2021-09-27 Thread Lieberman, Ron via cfe-commits
...@skidmore.edu; blitzrak...@gmail.com; shen...@google.com; david.gr...@arm.com; t...@google.com; Song, Ruiling Subject: [PATCH] D110429: [OpenMP] Introduce a new worksharing RTL function for distribute [CAUTION: External Email] jdoerfert added a comment. In D110429#3024886 <https://na

[PATCH] D110429: [OpenMP] Introduce a new worksharing RTL function for distribute

2021-09-27 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. In D110429#3024886 , @ronlieb wrote: > looks like subsequent builders passed. we might have an issue where the > runtime was not fully built when the test ran. > please disregard , your patch is fine. two dependent patches and

[PATCH] D110429: [OpenMP] Introduce a new worksharing RTL function for distribute

2021-09-27 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 added a comment. In D110429#3024884 , @ronlieb wrote: > lld: error: undefined symbol: __kmpc_distribute_static_init_4 > referenced by /tmp/private_mapping-6f3f07-gfx906-d001f0.o:(__omp_outlined__) referenced by /tmp/private_m

[PATCH] D110429: [OpenMP] Introduce a new worksharing RTL function for distribute

2021-09-27 Thread Ron Lieberman via Phabricator via cfe-commits
ronlieb added a comment. looks like subsequent builders passed. we might have an issue where the runtime was not fully built when the test ran. please disregard , your patch is fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110429/new/ https:

[PATCH] D110429: [OpenMP] Introduce a new worksharing RTL function for distribute

2021-09-27 Thread Ron Lieberman via Phabricator via cfe-commits
ronlieb added a comment. lld: error: undefined symbol: __kmpc_distribute_static_init_4 >>> referenced by /tmp/private_mapping-6f3f07-gfx906-d001f0.o:(__omp_outlined__) >>> referenced by /tmp/private_mapping-6f3f07-gfx906-d001f0.o:(__omp_outlined__) lld: error: undefined symbol: __kmpc_distribute

[PATCH] D110429: [OpenMP] Introduce a new worksharing RTL function for distribute

2021-09-27 Thread Ron Lieberman via Phabricator via cfe-commits
ronlieb added a comment. apologies, that pasted very poorly ... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110429/new/ https://reviews.llvm.org/D110429 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D110429: [OpenMP] Introduce a new worksharing RTL function for distribute

2021-09-27 Thread Ron Lieberman via Phabricator via cfe-commits
ronlieb added a comment. hi, we seem to have a link time error after this patch in our buildbot https://lab.llvm.org/staging/#/builders/182/builds/2023 - TEST 'libomptarget :: amdgcn-amd-amdhsa :: mapping/private_mapping.c' FAILED Script: --- : 'RUN: at line 1'; /w

[PATCH] D110429: [OpenMP] Introduce a new worksharing RTL function for distribute

2021-09-27 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG. We might be able to revert/simplify this eventually again but for now it makes it much simpler to distinguish the distribute and workshare (=for) via their call site. ===

[PATCH] D110429: [OpenMP] Introduce a new worksharing RTL function for distribute

2021-09-24 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992. Herald added subscribers: guansong, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added projects: clang, LLVM. This patch adds a new RTL fun