[PATCH] D110364: [clang] Rework dontcall attributes

aeubanks added a comment. In D110364#3028995 , @thakis wrote: > Looks like this breaks tests on windows: > http://45.33.8.238/win/46089/step_7.txt > > Please take a look, and revert for now if it takes a while to fix. Should be fixed with 2d56fbf6cd16bb

[PATCH] D110364: [clang] Rework dontcall attributes

thakis added a comment. Looks like this breaks tests on windows: http://45.33.8.238/win/46089/step_7.txt Please take a look, and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110364/new/ https://reviews.l

[PATCH] D110364: [clang] Rework dontcall attributes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2943071e2ee0: [clang] Rework dontcall attributes (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D110364: [clang] Rework dontcall attributes

aeubanks updated this revision to Diff 375698. aeubanks added a comment. DRY Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110364/new/ https://reviews.llvm.org/D110364 Files: clang/lib/CodeGen/CodeGenAction.cpp clang/lib/CodeGen/CodeGenModule.

[PATCH] D110364: [clang] Rework dontcall attributes

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. thanks for the patch! Comment at: llvm/lib/IR/DiagnosticInfo.cpp:408-427 + if (F->hasFnAttribute("dontcall-error")) { +unsigned LocCookie = 0; +aut

[PATCH] D110364: [clang] Rework dontcall attributes

aeubanks created this revision. Herald added subscribers: ormris, dexonsmith, jdoerfert, pengfei, steven_wu, hiraditya. aeubanks updated this revision to Diff 374663. aeubanks added a comment. aeubanks added reviewers: dblaikie, nickdesaulniers. aeubanks published this revision for review. Herald