This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
yaxunl marked an inline comment as done.
Closed by commit rGc4afb5f81b62: [HIP] Fix linking of asanrt.bc (authored by
yaxunl).
Herald added a project: clang.
Changed p
yaxunl marked an inline comment as done.
yaxunl added inline comments.
Comment at: clang/lib/Driver/ToolChains/HIP.cpp:413
} else
-BCLibs.push_back(AsanRTL.str());
+BCLibs.push_back({AsanRTL.str(), false});
}
tra wrote:
> Nit: I'd add
tra accepted this revision.
tra added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/lib/Driver/ToolChains/HIP.cpp:413
} else
-BCLibs.push_back(AsanRTL.str());
+BCLibs.push_back({AsanRTL.str(), false});
}
--
yaxunl updated this revision to Diff 374868.
yaxunl marked an inline comment as done.
yaxunl edited the summary of this revision.
yaxunl added a comment.
Revised by Artem's comments
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D110304/new/
https://reviews.llvm.org/D110304
Files:
clan
yaxunl marked an inline comment as done.
yaxunl added inline comments.
Comment at: clang/include/clang/Driver/ToolChain.h:116-117
+ // Enums corresponding to clang options for linking bitcode, i.e.,
+ // -mlink-builtin-bitcode or -mlink-bitcode-file
+ enum BitCodeLinkOpt {
-
tra added inline comments.
Comment at: clang/include/clang/Driver/ToolChain.h:116-117
+ // Enums corresponding to clang options for linking bitcode, i.e.,
+ // -mlink-builtin-bitcode or -mlink-bitcode-file
+ enum BitCodeLinkOpt {
It appears that what we deal
yaxunl created this revision.
yaxunl added a reviewer: tra.
Herald added subscribers: kerbowa, nhaehnle, jvesely.
yaxunl requested review of this revision.
HIP currently uses -mlink-builtin-bitcode to link all bitcode libraries, which
changes the linkage of functions to be internal once they are l
