This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG840afbde48e9: [PowerPC] SemaChecking for darn family of
builtins (authored by Conanap).
Changed prior to commit:
https://reviews.llvm.org/D110282?
amyk accepted this revision as: amyk.
amyk added a comment.
Thanks for updating the tests and description, Albion.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D110282/new/
https://reviews.llvm.org/D110282
___
cfe-commits mailing list
cfe-com
Conanap updated this revision to Diff 374565.
Conanap added a comment.
Moved test case back to original file and use `#ifdef __PPC64__` instead
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D110282/new/
https://reviews.llvm.org/D110282
Files:
clang/lib/Sema/SemaChecking.cpp
clang/te
amyk added inline comments.
Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-darn-32.c:13
+int testdarn_32(void) {
+ return __darn_32();
+}
Conanap wrote:
> amyk wrote:
> > lei wrote:
> > > Isn't this valid for both 32 and 64bit?
> > > Maybe change one of th
amyk added inline comments.
Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-darn-32.c:13
+int testdarn_32(void) {
+ return __darn_32();
+}
lei wrote:
> Isn't this valid for both 32 and 64bit?
> Maybe change one of the run lines above to a 64bit test.
I agre
Conanap added inline comments.
Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-darn-32.c:13
+int testdarn_32(void) {
+ return __darn_32();
+}
lei wrote:
> Isn't this valid for both 32 and 64bit?
> Maybe change one of the run lines above to a 64bit test.
It
lei accepted this revision as: lei.
lei added a comment.
This revision is now accepted and ready to land.
LGTM.
Pleases address the test issue on commit.
Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-darn-32.c:13
+int testdarn_32(void) {
+ return __darn_32();
+}
---
Conanap updated this revision to Diff 374329.
Conanap added a comment.
Added error testing
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D110282/new/
https://reviews.llvm.org/D110282
Files:
clang/lib/Sema/SemaChecking.cpp
clang/test/CodeGen/builtins-ppc-xlcompat-darn-32.c
clang/te
Conanap created this revision.
Conanap added reviewers: PowerPC, nemanjai, saghir, stefanp.
Conanap added projects: PowerPC, clang, LLVM.
Herald added a subscriber: kbarton.
Conanap requested review of this revision.
The `__darn` family of builtins are only available on Pwr9,
and only `__darn_32`
