This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG29bb877499ce: [PowerPC] Fix lharx and lbarx builtin
signatures (authored by Conanap).
Changed prior to commit:
https://reviews.llvm.org/D110273?vs
amyk added a comment.
Additional nit regarding the description and comment:
The signatures for the PowerPC builtins lharx and
lbarx are incorrect, and causes issues when in a function
that requiers the return of the builtin to be promoted.
This patch fixes these signatures.
Updated to:
The sign
nemanjai accepted this revision.
nemanjai added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D110273/new/
https://reviews.llvm.org/D110273
___
cfe-commits mailing list
Conanap updated this revision to Diff 374908.
Conanap added a comment.
Fixed an old test case
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D110273/new/
https://reviews.llvm.org/D110273
Files:
clang/include/clang/Basic/BuiltinsPPC.def
clang/test/CodeGen/builtins-ppc-xlcompat-LoadRes
NeHuang added inline comments.
Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-LoadReseve-StoreCond.c:27
char test_lbarx(volatile unsigned char *a) {
// CHECK-LABEL: @test_lbarx
Do you also need to update the input argument type here as well to match t
Conanap updated this revision to Diff 374556.
Conanap added a comment.
Added test cases
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D110273/new/
https://reviews.llvm.org/D110273
Files:
clang/include/clang/Basic/BuiltinsPPC.def
clang/test/CodeGen/builtins-ppc-xlcompat-LoadReseve-St
nemanjai added a comment.
The description says it causes issues but there is no test case. Please add the
test case that causes issues.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D110273/new/
https://reviews.llvm.org/D110273
___
Conanap created this revision.
Conanap added reviewers: PowerPC, nemanjai, stefanp, saghir.
Conanap added projects: clang, LLVM, PowerPC.
Herald added subscribers: steven.zhang, kbarton.
Conanap requested review of this revision.
The signatures for the PowerPC builtins `lharx` and
`lbarx` are inco
