[PATCH] D110260: [ORC] Minor renaming and typo fixes (NFC)

sgraenitz added a comment. FYI Included one more typo fix in ExecutorAddress.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110260/new/ https://reviews.llvm.org/D110260 ___ cfe-commits mailing list cfe-

[PATCH] D110260: [ORC] Minor renaming and typo fixes (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG767b328e506e: [ORC] Minor renaming and typo fixes (NFC) (authored by sgraenitz). Changed prior to commit: https://reviews.llvm.org/D110260?vs=3742

[PATCH] D110260: [ORC] Minor renaming and typo fixes (NFC)

xgupta added a comment. Problem is fixed with D110345 , Thank you very much for quick fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110260/new/ https://reviews.llvm.org/D110260

[PATCH] D110260: [ORC] Minor renaming and typo fixes (NFC)

xgupta added a comment. In D110260#3018555 , @sgraenitz wrote: > Interesting, it does work for me now on macOS with both, shared libs on and > off. Can you please check if you get something like this as well: > > ➜ nm bin/LLJITWithExecutorProcessContro

[PATCH] D110260: [ORC] Minor renaming and typo fixes (NFC)

sgraenitz added a comment. In D110260#3018412 , @xgupta wrote: > Yeah we need testcases, now it says > > JIT session error: Symbols not found: [ return1 ] > JIT session error: Failed to materialize symbols: { (main, { foo_body }) } > Unable to lazily comp

[PATCH] D110260: [ORC] Minor renaming and typo fixes (NFC)

xgupta accepted this revision. xgupta added a comment. This revision is now accepted and ready to land. In D110260#3018110 , @sgraenitz wrote: > Thanks @xgupta for your note! The parameter passed to > `EPCIndirectionUtils::Create()` in the example was re

[PATCH] D110260: [ORC] Minor renaming and typo fixes (NFC)

sgraenitz added a comment. Thanks @xgupta for your note! The parameter passed to `EPCIndirectionUtils::Create()` in the example was referencing a moved-from value. This caused the segfault. Unfortunately, the examples don't have good test coverage so far. Repository: rG LLVM Github Monorepo

[PATCH] D110260: [ORC] Minor renaming and typo fixes (NFC)

xgupta added a comment. Although this patch is correct, running ./LLJITWithTargetProcessControl result in segmentation fault. PLEASE submit a bug report to https://bugs.llvm.org/ and include the crash backtrace. Stack dump: 0. Program arguments: ./LLJITWithTargetProcessControl #0 0x7f

[PATCH] D110260: [ORC] Minor renaming and typo fixes (NFC)

sgraenitz created this revision. sgraenitz added a reviewer: lhames. Herald added subscribers: hiraditya, mgorny. sgraenitz requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: cfe-commits. One typo, one unsused include and some leftovers from the Targe