[PATCH] D110258: [AArch64][Clang] Always add -tune-cpu argument to -cc1 driver

paulwalker-arm added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:1850 + else +TuneCPU = "generic"; +} else What benefit does `-tune-cpu generic` provide? I'm wondering if the patch can be restricted to only add `-tune-cpu`

[PATCH] D110258: [AArch64][Clang] Always add -tune-cpu argument to -cc1 driver

dmgreen added a comment. In D110258#3015484 , @david-arm wrote: > Hi @dmgreen, this is specifically being introduced for SVE targets to help > make informed cost model decisions regarding the value of vscale - see > D110259

[PATCH] D110258: [AArch64][Clang] Always add -tune-cpu argument to -cc1 driver

david-arm added a comment. Hi @dmgreen, this is specifically being introduced for SVE targets to help make informed cost model decisions regarding the value of vscale - see D110259 . We thought that using the "tune-cpu" attribute might be a good way of doing th

[PATCH] D110258: [AArch64][Clang] Always add -tune-cpu argument to -cc1 driver

dmgreen added a comment. My understanding is that -mtune doesn't work sensibly for Arm backends. The tuning features and architecture features are not separated out at the subtarget level. Is the idea to teach people to start using it? That sounds dangerous without fixing the issues with it fi

[PATCH] D110258: [AArch64][Clang] Always add -tune-cpu argument to -cc1 driver

david-arm created this revision. david-arm added reviewers: sdesmalen, c-rhodes, peterwaller-arm, dmgreen. Herald added a subscriber: kristof.beyls. david-arm requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch ensures that we always