[PATCH] D110252: Added note about Whatstyle and Unformat

2023-10-25 Thread Owen Pan via Phabricator via cfe-commits
owenpan commandeered this revision. owenpan edited reviewers, added: Volker-Weissmann; removed: owenpan. Herald added a project: All. Herald added a comment. NOTE: Clang-Format Team Automated Review Comment Your review contains a change to ClangFormatStyleOptions.rst but not a change to clang/in

[PATCH] D110252: Added note about Whatstyle and Unformat

2021-10-06 Thread Volker Weißmann via Phabricator via cfe-commits
Volker-Weissmann added a comment. I understand your concerns, it isn't meant as an endorsement. I took me quite a while too find them with google, so I thought I make it faster for the next one after me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D110252: Added note about Whatstyle and Unformat

2021-10-06 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks resigned from this revision. HazardyKnusperkeks added a comment. I too think this should not directly mentioned in clang-format documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110252/new/ https://reviews.llvm.org/D11

[PATCH] D110252: Added note about Whatstyle and Unformat

2021-10-04 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. IMHO is that I don't personally feel we need to endorse of someone else's that could be potentially incomplete, These tools are interesting (per say) but I have no idea how accurate they are in terms of using all the options or how much they keep pace, for every

[PATCH] D110252: Added note about Whatstyle and Unformat

2021-09-25 Thread Volker Weißmann via Phabricator via cfe-commits
Volker-Weissmann added a comment. In D110252#3018375 , @MyDeveloperDay wrote: > Whatstyle has not been updated since Dec 2020, is it going to cover the > latest style configuration options? No it doesn't. As I wrote, both work on a best-effort basis.

[PATCH] D110252: Added note about Whatstyle and Unformat

2021-09-23 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. Whatstyle has not been updated since Dec 2020, is it going to cover the latest style configuration options? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110252/new/ https://reviews.llvm.org/D110252 ___

[PATCH] D110252: Added note about Whatstyle and Unformat

2021-09-22 Thread Volker Weißmann via Phabricator via cfe-commits
Volker-Weissmann created this revision. Volker-Weissmann added a reviewer: sdesmalen. Volker-Weissmann requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I added a note about Whatstyle and Unformat