nridge updated this revision to Diff 374130.
nridge added a comment.
address review comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D110130/new/
https://reviews.llvm.org/D110130
Files:
clang-tools-extra/clangd/SemanticHighlighting.cpp
cl
kadircet added a comment.
Naming of the patch is a little bit confusing. We're actually dropping the
semantic highlighting for the type of lambdacaptures, which was showing up in
the declarator names since there was no explicit type spelled in the source
code. This turns on highlighting for the
nridge added inline comments.
Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:522
+ // is the same as the location of the declared name itself.
+ if (StartLoc != D->getLocation()) {
+auto &Tok =
Note, I initially tried `D->getTypeS
nridge created this revision.
nridge added a reviewer: kadircet.
Herald added subscribers: usaxena95, arphaman.
nridge requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.
Repository:
rG LLVM Github Monorepo
