[PATCH] D110130: [clangd] Ensure lambda init-capture gets semantic token

2021-09-23 Thread Nathan Ridge via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4223195de3ea: [clangd] Ensure lambda init-capture gets semantic token (authored by nridge). Changed prior to commit: https://reviews.llvm.org/D110

[PATCH] D110130: [clangd] Ensure lambda init-capture gets semantic token

2021-09-23 Thread Nathan Ridge via Phabricator via cfe-commits
nridge updated this revision to Diff 374461. nridge marked 3 inline comments as done. nridge added a comment. address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110130/new/ https://reviews.llvm.org/D110130 Files: clang-tools-e

[PATCH] D110130: [clangd] Ensure lambda init-capture gets semantic token

2021-09-22 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added a comment. thanks, LGTM! Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:518 + SourceLocation StartLoc = D->getTypeSpecStartLoc(); + // The AutoType may not have a corresponding token, e.g. in the case of + // init-captures, so there'

[PATCH] D110130: [clangd] Ensure lambda init-capture gets semantic token

2021-09-22 Thread Nathan Ridge via Phabricator via cfe-commits
nridge marked an inline comment as done. nridge added a comment. In D110130#3012748 , @kadircet wrote: > Naming of the patch is a little bit confusing. We're actually dropping the > semantic highlighting for the type of lambdacaptures, which was showing