[PATCH] D110051: [clangd] Deduplicate inlay hints

This revision was automatically updated to reflect the committed changes. Closed by commit rGd87d1aa07612: [clangd] Deduplicate inlay hints (authored by nridge). Changed prior to commit: https://reviews.llvm.org/D110051?vs=373782&id=373790#toc Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D110051: [clangd] Deduplicate inlay hints

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! > I don't think we're likely to get a parameter hint and a type hint at the > same location, but if you're concerned, I could revise the patch to ignore > the hint kind duri

[PATCH] D110051: [clangd] Deduplicate inlay hints

nridge updated this revision to Diff 373782. nridge added a comment. address nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110051/new/ https://reviews.llvm.org/D110051 Files: clang-tools-extra/clangd/InlayHints.cpp clang-tools-extra/clangd

[PATCH] D110051: [clangd] Deduplicate inlay hints

nridge added a comment. In D110051#3009378 , @kadircet wrote: > I am not aware of how the intersecting hints are handled in the > implementation on the client side nor in the proposal today. After this patch > we might still produce them if for whatever

[PATCH] D110051: [clangd] Deduplicate inlay hints

kadircet added a comment. I am not aware of how the intersecting hints are handled in the implementation on the client side nor in the proposal today. After this patch we might still produce them if for whatever reason there are different kinds of hints for the same range. Is this OK? ==

[PATCH] D110051: [clangd] Deduplicate inlay hints

nridge added a comment. I will note that I considered handling this in a way specific to explicit template instantiations. However, while I do not have a reduced testcase for it, I've also run into duplicate hints in the context of macros. So, it seemed easier to deduplicate in general; there

[PATCH] D110051: [clangd] Deduplicate inlay hints

nridge created this revision. nridge added reviewers: kadircet, sammccall. Herald added subscribers: usaxena95, arphaman, mgrang. nridge requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Duplicates can somet