This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGea79b77da3ee: [clangd] Dont work on diags if we are not
going to emit (authored by kadircet).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE L
kadircet updated this revision to Diff 372947.
kadircet added a comment.
- Revert revert of IncludeFixer changes
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109884/new/
https://reviews.llvm.org/D109884
Files:
clang-tools-extra/clangd/ParsedAST
kadircet updated this revision to Diff 372943.
kadircet marked 2 inline comments as done.
kadircet added a comment.
- Get rid of static_casts
- Update comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109884/new/
https://reviews.llvm.org/D1098
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/unittests/ParsedASTTests.cpp:464
-
- TU.AdditionalFiles["a.h"] = "";
- TU.AdditionalFiles["b.h"] = "";
kadir
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/unittests/ParsedASTTests.cpp:464
-
- TU.AdditionalFiles["a.h"] = "";
- TU.AdditionalFiles["b.h"] = "";
sammccall wrote:
> Why are these tests deleted?
they rely on the fact that clang-tidy che
sammccall added a comment.
Great!
Comment at: clang-tools-extra/clangd/ParsedAST.cpp:295
llvm::MemoryBuffer::getMemBufferCopy(Inputs.Contents, Filename), VFS,
- ASTDiags);
+ PreserveDiags ? static_cast(ASTDiags)
+: static_cast(DropDiags));
-
kadircet updated this revision to Diff 372938.
kadircet added a comment.
- Disable IncludeFixer too.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109884/new/
https://reviews.llvm.org/D109884
Files:
clang-tools-extra/clangd/ParsedAST.cpp
clang
kadircet created this revision.
kadircet added a reviewer: sammccall.
Herald added subscribers: usaxena95, arphaman.
kadircet requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.
Doesn't install clang-tidy chec
