[PATCH] D109880: [clangd] PreamblePatch should be no-op if includes arent patched

2021-09-16 Thread Kadir Cetinkaya via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. kadircet marked an inline comment as done. Closed by commit rG64fe0458866d: [clangd] PreamblePatch should be no-op if includes arent patched (authored by kadircet). Changed prior to commit: https://reviews.llvm.org/D10988

[PATCH] D109880: [clangd] PreamblePatch should be no-op if includes arent patched

2021-09-16 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/Preamble.cpp:462 BaselineScan->TextualDirectives != ModifiedScan->TextualDirectives; - if (!IncludesChanged && !Directi

[PATCH] D109880: [clangd] PreamblePatch should be no-op if includes arent patched

2021-09-16 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Don't create a useless function