[PATCH] D109854: Support Unicode 14 identifiers

2021-09-16 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman closed this revision. aaron.ballman added a comment. I committed this on your behalf in afb6223bc53034973379863d08cbee322149569e , thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D109854: Support Unicode 14 identifiers

2021-09-16 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with a minor comment on comments that I'll handle when I land this. Comment at: clang/test/Lexer/unicode.c:37-41 +extern int \u1B4C; //BALINESE LETTER

[PATCH] D109854: Support Unicode 14 identifiers

2021-09-16 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin updated this revision to Diff 372915. cor3ntin added a comment. Added some tests for randomly choosen Unicode 14 codepoints Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109854/new/ https://reviews.llvm.org/D109854 Files: clang/lib/Lex/

[PATCH] D109854: Support Unicode 14 identifiers

2021-09-16 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. Thanks for this! Can you add a test case that shows we now accept some Unicode 14 characters that Clang previously would have rejected (with a comment explaining what's being tested)? Comment at: clang/lib/Lex/UnicodeCharSets.h:13 // Unicode

[PATCH] D109854: Support Unicode 14 identifiers This update the UAX tables to support new Unicode 14 identifiers

2021-09-15 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin created this revision. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D109854 Files: clang/lib/Lex/UnicodeCharSets.h Index: clang/lib/Lex/UnicodeCharSets