This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGab5f2b505a07: [HIP] Diagnose -fopenmp-targets for HIP
programs (authored by yaxunl).
Herald added a project: clang.
Repository:
rG LLVM Github Mon
yaxunl updated this revision to Diff 372495.
yaxunl added a comment.
revise diag message
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109718/new/
https://reviews.llvm.org/D109718
Files:
clang/include/clang/Basic/DiagnosticDriverKinds.td
clang/lib/Driver/Driver.cpp
clang/test/Dri
tra added inline comments.
Comment at: clang/lib/Driver/Driver.cpp:704
+C.getInputArgs().getLastArg(options::OPT_fopenmp_targets_EQ)) {
+ Diag(clang::diag::err_drv_unsupported_opt) <<
OMPTargetArg->getSpelling();
+ return;
yaxunl wrote:
> t
yaxunl added inline comments.
Comment at: clang/lib/Driver/Driver.cpp:704
+C.getInputArgs().getLastArg(options::OPT_fopenmp_targets_EQ)) {
+ Diag(clang::diag::err_drv_unsupported_opt) <<
OMPTargetArg->getSpelling();
+ return;
tra wrote:
> I
tra added inline comments.
Comment at: clang/lib/Driver/Driver.cpp:704
+C.getInputArgs().getLastArg(options::OPT_fopenmp_targets_EQ)) {
+ Diag(clang::diag::err_drv_unsupported_opt) <<
OMPTargetArg->getSpelling();
+ return;
I think "unsuppor
yaxunl created this revision.
yaxunl added a reviewer: tra.
Herald added a subscriber: guansong.
yaxunl requested review of this revision.
Herald added a reviewer: jdoerfert.
Herald added a subscriber: sstefan1.
Diagnose -fopenmp-targets for HIP programs since dual HIP and OpenMP offloading
in th
