[PATCH] D109654: [clang] disable implicit moves when not in CPlusPLus

thakis added a comment. I bet my issue is due to D108243 and not this change. Sorry for the noise! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109654/new/ https://reviews.llvm.org/D109654 _

[PATCH] D109654: [clang] disable implicit moves when not in CPlusPLus

mizvekov added a comment. In D109654#3002862 , @thakis wrote: > Yes, https://bugs.chromium.org/p/chromium/issues/detail?id=1250052 I haven't > yet verified it's definitely due to this change, but it's the most > related-looking change in the regression

[PATCH] D109654: [clang] disable implicit moves when not in CPlusPLus

thakis added a comment. Yes, https://bugs.chromium.org/p/chromium/issues/detail?id=1250052 I haven't yet verified it's definitely due to this change, but it's the most related-looking change in the regression range. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D109654: [clang] disable implicit moves when not in CPlusPLus

mizvekov added a comment. In D109654#3002632 , @thakis wrote: > Is it possible that this disabled this for Objective-C++ too? As far as I understand, CPlusPLus will be set on ObjectiveC++ as well, and I think we do have test coverage there, but I haven'

[PATCH] D109654: [clang] disable implicit moves when not in CPlusPLus

thakis added a comment. Is it possible that this disabled this for Objective-C++ too? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109654/new/ https://reviews.llvm.org/D109654 ___ cfe-commits mailing li

[PATCH] D109654: [clang] disable implicit moves when not in CPlusPLus

This revision was automatically updated to reflect the committed changes. Closed by commit rG2d6829bbbe68: [clang] disable implicit moves when not in CPlusPLus (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109654/new/ https:/

[PATCH] D109654: [clang] disable implicit moves when not in CPlusPLus

mizvekov updated this revision to Diff 372434. mizvekov edited the summary of this revision. mizvekov added a comment. include repro for analyzer crash. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109654/new/ https://reviews.llvm.org/D109654 Fil

[PATCH] D109654: [clang] disable implicit moves when not in CPlusPLus

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thanks a lot!! This seems to take care of my issues. Can you also include the following test case somewhere into, say, `test/Analysis/blocks-nrvo.c`? It crashes without this patch. // RUN: %clang

[PATCH] D109654: [clang] disable implicit moves when not in CPlusPLus

mizvekov created this revision. mizvekov updated this revision to Diff 372103. mizvekov added a comment. mizvekov published this revision for review. mizvekov added a reviewer: NoQ. Herald added a project: clang. Herald added a subscriber: cfe-commits. . This simplifies the AST a little bit when