This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG5eaf5b916146: [PowerPC] Restrict various P10 options to P10
only. (authored by amyk).
Changed prior to commit:
https://reviews.llvm.org/D109652?vs
lei accepted this revision.
lei added a comment.
LGTM
I think you went a bit overkill with the tests for this patch 🙂. Please cut
down the number of run lines before committing.
Comment at: clang/test/Driver/ppc-p10-features-support-check.c:4
+// RUN: --check-prefix=HASPAIR
amyk added a comment.
Ping @lei.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109652/new/
https://reviews.llvm.org/D109652
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/
amyk added a comment.
Ping.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109652/new/
https://reviews.llvm.org/D109652
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-b
amyk updated this revision to Diff 374990.
amyk edited the summary of this revision.
amyk added a comment.
Addressed Lei's review comments to output:
error: option '-mpcrel' cannot be specified without '-mcpu=pwr10 -mprefixed'
when PC-Rel is specified pre-P10.
Also updated the comment for MMA
lei added inline comments.
Comment at: clang/lib/Basic/Targets/PPC.cpp:566-569
+ if (llvm::find(FeaturesVec, "+pcrel") != FeaturesVec.end()) {
+Diags.Report(diag::err_opt_not_valid_without_opt) << "-mpcrel"
+ <
Conanap accepted this revision.
Conanap added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109652/new/
https://reviews.llvm.org/D109652
_
amyk created this revision.
amyk added reviewers: PowerPC, nemanjai, stefanp.
amyk added projects: LLVM, PowerPC.
Herald added subscribers: shchenz, kbarton.
amyk requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
This patch attempts to restri
