[PATCH] D109635: [OpenMP] Support construct trait set for Clang

2021-09-16 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:741 +llvm::omp::TraitProperty Top = ConstructTraits.pop_back_val(); +assert(Top == Trait && "Something left a trait on the stack!"); + } I fixed -Wunused-variable in c5f

[PATCH] D109635: [OpenMP] Support construct trait set for Clang

2021-09-16 Thread Chi Chun Chen via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG976d474bec35: [OpenMP] Support construct trait set for Clang (authored by cchen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D109635: [OpenMP] Support construct trait set for Clang

2021-09-15 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM, thanks :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109635/new/ https://reviews.llvm.org/D109635 __