This revision was automatically updated to reflect the committed changes.
Closed by commit rG80d62993d072: [clang][darwin] Add support for
--emit-static-lib (authored by keith).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109461/new/
https://revie
yaxunl accepted this revision.
yaxunl added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109461/new/
https://reviews.llvm.org/D109461
__
keith updated this revision to Diff 372287.
keith added a comment.
Revert unrelated formatting fixes
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109461/new/
https://reviews.llvm.org/D109461
Files:
clang/lib/Driver/ToolChain.cpp
clang/lib/Dri
keith updated this revision to Diff 372286.
keith marked an inline comment as done.
keith added a comment.
Fix formatting and comment
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109461/new/
https://reviews.llvm.org/D109461
Files:
clang/lib/Dri
yaxunl added inline comments.
Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:748
+
+ // ar tool command "llvm-ar ".
+ ArgStringList CmdArgs;
libtool ?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109461/ne
keith added reviewers: ashi1, tra, yaxunl.
keith added a comment.
Since you all were involved in adding this feature in the beginning I'd
appreciate a review!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109461/new/
https://reviews.llvm.org/D1094
keith created this revision.
keith requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
This uses darwin's default libtool since llvm-ar isn't normally
available.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D109461
Files:
