This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG70391b3468b8: [PowerPC] FP compare and test XL compat
builtins. (authored by quinnp).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTI
quinnp updated this revision to Diff 374891.
quinnp added a comment.
Rebase with main.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109437/new/
https://reviews.llvm.org/D109437
Files:
clang/include/clang/Basic/BuiltinsPPC.def
clang/include/cl
quinnp updated this revision to Diff 374888.
quinnp added a comment.
Addressing nit in SemaChecking.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109437/new/
https://reviews.llvm.org/D109437
Files:
clang/include/clang/Basic/BuiltinsPPC.def
cl
lei accepted this revision as: lei.
lei added a comment.
LGTM
Pleases address nit on commit.
Comment at: clang/lib/Sema/SemaChecking.cpp:3495-3496
+ArgType != QualType(Context.DoubleTy)) {
+ Diag(TheCall->getBeginLoc(), diag::err_ppc_invalid_test_data_class_type);
quinnp updated this revision to Diff 374610.
quinnp added a comment.
Addressing review comment about ISelLowering of `test_data_class`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109437/new/
https://reviews.llvm.org/D109437
Files:
clang/inclu
quinnp updated this revision to Diff 374605.
quinnp added a comment.
Addressing some review comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109437/new/
https://reviews.llvm.org/D109437
Files:
clang/include/clang/Basic/BuiltinsPPC.def
c
lei requested changes to this revision.
lei added inline comments.
This revision now requires changes to proceed.
Comment at: clang/include/clang/Sema/Sema.h:12680
bool CheckPPCMMAType(QualType Type, SourceLocation TypeLoc);
+ bool CheckPPCTestDataClassType(CallExpr *TheCall)
quinnp updated this revision to Diff 374312.
quinnp added a comment.
Moving the semachecking of `test_data_class` from the function to the switch
case.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109437/new/
https://reviews.llvm.org/D109437
Fil
quinnp updated this revision to Diff 374064.
quinnp added a comment.
Separating the switch case in ISelLowering into two switch cases. One for
`compare_exp_` and another for `test_data_class`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109437/ne
kamaub added inline comments.
Comment at: clang/lib/Sema/SemaChecking.cpp:3518
+// valid. The argument must be either a 'float' or a 'double'.
+bool Sema::CheckPPCTestDataClassType(CallExpr *TheCall) {
+ QualType ArgType = TheCall->getArg(0)->getType();
lei wrot
lei added inline comments.
Comment at: clang/lib/Sema/SemaChecking.cpp:3518
+// valid. The argument must be either a 'float' or a 'double'.
+bool Sema::CheckPPCTestDataClassType(CallExpr *TheCall) {
+ QualType ArgType = TheCall->getArg(0)->getType();
I don't thi
Conanap added inline comments.
Comment at: clang/lib/Sema/SemaChecking.cpp:3490
+ SemaBuiltinConstantArgRange(TheCall, 1, 0, 127) ||
+ CheckPPCTestDataClassType(TheCall);
#define CUSTOM_BUILTIN(Name, Intr, Types, Acc) \
If you're making a fun
quinnp updated this revision to Diff 372243.
quinnp added a comment.
Adding SemaChecking for the first argument of __builitn_ppc_test_data_class so
the llvm_unreachable in CGBuiltin is actually unreachable.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.o
quinnp created this revision.
Herald added subscribers: shchenz, kbarton, hiraditya, nemanjai.
quinnp requested review of this revision.
Herald added projects: clang, LLVM.
Herald added subscribers: llvm-commits, cfe-commits.
This patch is in a series of patches to provide builtins for
compatabili
14 matches
Mail list logo
