[PATCH] D109362: [SystemZ][z/OS] Add GOFF Support to the DataLayout

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. anirudhp marked an inline comment as done. Closed by commit rGe09a1dc47515: [SystemZ][z/OS] Add GOFF Support to the DataLayout (authored by anirudhp). Repository: rG

[PATCH] D109362: [SystemZ][z/OS] Add GOFF Support to the DataLayout

anirudhp marked 2 inline comments as done. anirudhp added inline comments. Comment at: clang/test/CodeGen/target-data.c:256 +// RUN: %clang_cc1 -triple s390x-none-zos -o - -emit-llvm %s | \ +// RUN: FileCheck %s -check-prefix=ZOS MaskRay wrote: > MaskRay wrote:

[PATCH] D109362: [SystemZ][z/OS] Add GOFF Support to the DataLayout

MaskRay accepted this revision. MaskRay added a comment. Thanks for cleaning up RUN lines :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109362/new/ https://reviews.llvm.org/D109362 ___ cfe-commits mai

[PATCH] D109362: [SystemZ][z/OS] Add GOFF Support to the DataLayout

uweigand added a comment. In D109362#3013253 , @anirudhp wrote: > - Reduced the number of test lines in target-data.c, since we don't have to > check for every combination of arch,cpu for the SystemZ target (for both elf > and z/OS) These changes still

[PATCH] D109362: [SystemZ][z/OS] Add GOFF Support to the DataLayout

anirudhp updated this revision to Diff 373999. anirudhp added a comment. - Reduced the number of test lines in target-data.c, since we don't have to check for every combination of arch,cpu for the SystemZ target (for both elf and z/OS) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D109362: [SystemZ][z/OS] Add GOFF Support to the DataLayout

MaskRay added inline comments. Comment at: clang/test/CodeGen/target-data.c:256 +// RUN: %clang_cc1 -triple s390x-none-zos -o - -emit-llvm %s | \ +// RUN: FileCheck %s -check-prefix=ZOS MaskRay wrote: > anirudhp wrote: > > MaskRay wrote: > > > If you add so man

[PATCH] D109362: [SystemZ][z/OS] Add GOFF Support to the DataLayout

MaskRay added inline comments. Comment at: clang/test/CodeGen/target-data.c:256 +// RUN: %clang_cc1 -triple s390x-none-zos -o - -emit-llvm %s | \ +// RUN: FileCheck %s -check-prefix=ZOS anirudhp wrote: > MaskRay wrote: > > If you add so many RUN lines at once,

[PATCH] D109362: [SystemZ][z/OS] Add GOFF Support to the DataLayout

anirudhp added inline comments. Comment at: clang/test/CodeGen/target-data.c:256 +// RUN: %clang_cc1 -triple s390x-none-zos -o - -emit-llvm %s | \ +// RUN: FileCheck %s -check-prefix=ZOS MaskRay wrote: > If you add so many RUN lines at once, please use unittest

[PATCH] D109362: [SystemZ][z/OS] Add GOFF Support to the DataLayout

MaskRay added inline comments. Comment at: clang/test/CodeGen/target-data.c:256 +// RUN: %clang_cc1 -triple s390x-none-zos -o - -emit-llvm %s | \ +// RUN: FileCheck %s -check-prefix=ZOS If you add so many RUN lines at once, please use unittests instead. This wo

[PATCH] D109362: [SystemZ][z/OS] Add GOFF Support to the DataLayout

uweigand accepted this revision. uweigand added a comment. This LGTM now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109362/new/ https://reviews.llvm.org/D109362 ___ cfe-commits mailing list cfe-commi

[PATCH] D109362: [SystemZ][z/OS] Add GOFF Support to the DataLayout

anirudhp updated this revision to Diff 372737. anirudhp added a comment. - Update to the documentation as well in account for the update to the global prefix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109362/new/ https://reviews.llvm.org/D1093

[PATCH] D109362: [SystemZ][z/OS] Add GOFF Support to the DataLayout

uweigand added inline comments. Comment at: llvm/docs/LangRef.rst:2596 * ``e``: ELF mangling: Private symbols get a ``.L`` prefix. +* ``l``: GOFF mangling: Private symbols get a ``.L`` prefix. * ``m``: Mips mangling: Private symbols get a ``$`` prefix. -

[PATCH] D109362: [SystemZ][z/OS] Add GOFF Support to the DataLayout

anirudhp added a comment. In D109362#3001294 , @uweigand wrote: > In D109362#3000284 , @anirudhp > wrote: > >> In D109362#2999688 , @uweigand >> wrote: >> >>> Looking at

[PATCH] D109362: [SystemZ][z/OS] Add GOFF Support to the DataLayout

anirudhp updated this revision to Diff 372733. anirudhp added a comment. - Introduce separate label prefix for `MM_GOFF` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109362/new/ https://reviews.llvm.org/D109362 Files: clang/lib/Basic/Targets/Sy

[PATCH] D109362: [SystemZ][z/OS] Add GOFF Support to the DataLayout

uweigand added a comment. In D109362#3000284 , @anirudhp wrote: > In D109362#2999688 , @uweigand > wrote: > >> Looking at the common code parts, it seems the behavior of MM_GOFF is >> actually identical to MM_EL

[PATCH] D109362: [SystemZ][z/OS] Add GOFF Support to the DataLayout

anirudhp added a comment. In D109362#2999688 , @uweigand wrote: > Looking at the common code parts, it seems the behavior of MM_GOFF is > actually identical to MM_ELF. Is this correct? If so, do we really need a > different format type here? At a f

[PATCH] D109362: [SystemZ][z/OS] Add GOFF Support to the DataLayout

uweigand added a comment. Looking at the common code parts, it seems the behavior of MM_GOFF is actually identical to MM_ELF. Is this correct? If so, do we really need a different format type here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D109362: [SystemZ][z/OS] Add GOFF Support to the DataLayout

anirudhp added a comment. Ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109362/new/ https://reviews.llvm.org/D109362 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D109362: [SystemZ][z/OS] Add GOFF Support to the DataLayout

abhina.sreeskantharajan accepted this revision. abhina.sreeskantharajan added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109362/new/ https://reviews.llvm.org/D109362 ___ cfe-commits ma

[PATCH] D109362: [SystemZ][z/OS] Add GOFF Support to the DataLayout

Kai accepted this revision. Kai added a comment. This revision is now accepted and ready to land. LGTM. Thanks for the documentation update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109362/new/ https://reviews.llvm.org/D109362 ___

[PATCH] D109362: [SystemZ][z/OS] Add GOFF Support to the DataLayout

anirudhp updated this revision to Diff 371106. anirudhp added a comment. - Condensed the lit test a bit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109362/new/ https://reviews.llvm.org/D109362 Files: clang/lib/Basic/Targets/SystemZ.h clang/

[PATCH] D109362: [SystemZ][z/OS] Add GOFF Support to the DataLayout

uweigand added a comment. SystemZ specific parts LGTM, but it would be good to have someone else review the common code / IR changes as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109362/new/ https://reviews.llvm.org/D109362 _

[PATCH] D109362: [SystemZ][z/OS] Add GOFF Support to the DataLayout

anirudhp created this revision. Herald added subscribers: dexonsmith, jdoerfert, hiraditya. anirudhp requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. - This patch adds in the GOFF mangling support to the LLVM data layout st