[PATCH] D109344: [AMDGPU][OpenMP] Use complex definitions from complex_cmath.h

jdoerfert added a comment. I'm fixing this, nothing to do with this patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109344/new/ https://reviews.llvm.org/D109344 ___ cfe-commits mailing list cfe-commi

[PATCH] D109344: [AMDGPU][OpenMP] Use complex definitions from complex_cmath.h

pdhaliwal added a comment. Even with declare variant separated using ifdef's, the error is still there. So I don't think we have workaround for this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109344/new/ https://reviews.llvm.org/D109344 _

[PATCH] D109344: [AMDGPU][OpenMP] Use complex definitions from complex_cmath.h

JonChesterfield added a comment. In D109344#2997495 , @jdoerfert wrote: > Can you please file a bug with a reproducer, I'm not sure I follow your > problem. Should be a case of trying to compile complex test cases for ovo for amdgpu immediately crashes

[PATCH] D109344: [AMDGPU][OpenMP] Use complex definitions from complex_cmath.h

jdoerfert added a comment. In D109344#2997454 , @JonChesterfield wrote: > Let's change to the uglier #ifdef for now, and add it to the short list of > things that aren't quite right in declare variant Can you please file a bug with a reproducer, I'm no

[PATCH] D109344: [AMDGPU][OpenMP] Use complex definitions from complex_cmath.h

JonChesterfield added a comment. Let's change to the uglier #ifdef for now, and add it to the short list of things that aren't quite right in declare variant Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109344/new/ https://reviews.llvm.org/D10934

[PATCH] D109344: [AMDGPU][OpenMP] Use complex definitions from complex_cmath.h

pdhaliwal added a comment. Hey, Jon, sorry for late reply. I cannot reproduce this issue on nvptx so it seems to occur only on amdgcn. Will it be better if instead the name mangling issue is fixed? Or for the meantime, I could add #ifdef around as a temporary fix. Suggestions? Repository: r

[PATCH] D109344: [AMDGPU][OpenMP] Use complex definitions from complex_cmath.h

JonChesterfield added a comment. I'm seeing crashes in this area when running OvO, e.g. 0. $HOME/OvO/test_src/cpp/mathematical_function/cpp11-complex/pow_complex_float_complex_float_complex_float.cpp 1. $HOME/OvO/test_src/cpp/mathematical_function/cpp11-complex/pow_complex_float_complex_flo

[PATCH] D109344: [AMDGPU][OpenMP] Use complex definitions from complex_cmath.h

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG12dcbf913c49: [AMDGPU][OpenMP] Use complex definitions from complex_cmath.h (authored by Pushpinder Singh ). Reposi

[PATCH] D109344: [AMDGPU][OpenMP] Use complex definitions from complex_cmath.h

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109344/new/ https://reviews.llvm.org/D109344 __

[PATCH] D109344: [AMDGPU][OpenMP] Use complex definitions from complex_cmath.h

pdhaliwal updated this revision to Diff 371008. pdhaliwal added a comment. Add amdgcn to the same arch list as nvptx Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109344/new/ https://reviews.llvm.org/D109344 Files: clang/lib/Headers/openmp_wrapp

[PATCH] D109344: [AMDGPU][OpenMP] Use complex definitions from complex_cmath.h

JonChesterfield added inline comments. Comment at: clang/lib/Headers/openmp_wrappers/complex:48 +#ifdef __NVPTX__ #pragma omp begin declare variant match( \ device = {arch(nvptx, nvptx64)}, \

[PATCH] D109344: [AMDGPU][OpenMP] Use complex definitions from complex_cmath.h

pdhaliwal created this revision. pdhaliwal added reviewers: ye-luo, jdoerfert, ronlieb, JonChesterfield. Herald added subscribers: guansong, t-tye, tpr, dstuttard, yaxunl, jvesely, kzhuravl. pdhaliwal requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, wdng. Herald