[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

gregmiller added a comment. The test patch worked and test is now passing again. Thanks for the quick help on this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109234/new/ https://reviews.llvm.org/D109234 __

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

thopre added a comment. In D109234#3004253 , @gregmiller wrote: > Hello, > We are maintaining a downstream version of the monorepo based on the LLVM > main branch. We have not transitioned to the new PM yet. In a recent attempt > to merge the latest u

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

gregmiller added a comment. Hello, We are maintaining a downstream version of the monorepo based on the LLVM main branch. We have not transitioned to the new PM yet. In a recent attempt to merge the latest upstream commits into our monorepo we came across the following test failures after your

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

This revision was automatically updated to reflect the committed changes. Closed by commit rG005fc11ebdd6: [PGO] Change ThinLTO test for targets with loop unrolling disabled (authored by Sherwin da Cruz <59867245+sherwin...@users.noreply.github.com>, committed by thopre). Repository: rG LLVM G

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

sherwin-dc added a comment. I dont have commit access, would someone be able to commit on my behalf? Thank You. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109234/new/ https://reviews.llvm.org/D109234 ___

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. lgtm, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109234/new/ https://reviews.llvm.org/D109234

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

sherwin-dc updated this revision to Diff 372749. sherwin-dc added a comment. - Modify test to correctly indicate old/new PM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109234/new/ https://reviews.llvm.org/D109234 Files: clang/test/CodeGen/pgo-

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

tejohnson added inline comments. Comment at: clang/test/CodeGen/pgo-sample-thinlto-summary.c:28 +// The first Unroll loop pass is the createSimpleLoopUnrollPass that unrolls and peels +// loops with small constant trip counts. Only the second one is handled by ThinLTO. +// THIN

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

sherwin-dc updated this revision to Diff 372720. sherwin-dc added a comment. - Modify test to correctly indicate old/new PM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109234/new/ https://reviews.llvm.org/D109234 Files: clang/test/CodeGen/pgo-

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

tejohnson added inline comments. Comment at: clang/test/CodeGen/pgo-sample-thinlto-summary.c:3 +// RUN: %clang_cc1 -mllvm -debug-pass=Structure -O2 -fno-experimental-new-pass-manager -fprofile-sample-use=%S/Inputs/pgo-sample-thinlto-summary.prof %s -emit-llvm -flto=thin -o - 2

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

thopre added inline comments. Comment at: clang/test/CodeGen/pgo-sample-thinlto-summary.c:3-4 +// RUN: %clang_cc1 -mllvm -debug-pass=Structure -O2 -fno-experimental-new-pass-manager -fprofile-sample-use=%S/Inputs/pgo-sample-thinlto-summary.prof %s -emit-llvm -flto=thin -o - 2>

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

sherwin-dc added inline comments. Comment at: clang/test/CodeGen/pgo-sample-thinlto-summary.c:27 +// THINLTO-OLDPM-NOT: PGOIndirectCallPromotion +// THINLTO-OLDPM: Unroll loops +// THINLTO-OLDPM-NOT: Unroll loops When printing out passes wit

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

sherwin-dc updated this revision to Diff 372696. sherwin-dc added a comment. - Modify test to correctly indicate old/new PM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109234/new/ https://reviews.llvm.org/D109234 Files: clang/test/CodeGen/pgo-

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

tejohnson added inline comments. Comment at: clang/test/CodeGen/pgo-sample-thinlto-summary.c:1 -// RUN: %clang_cc1 -O2 -fprofile-sample-use=%S/Inputs/pgo-sample-thinlto-summary.prof %s -emit-llvm -o - 2>&1 | FileCheck %s -check-prefix=SAMPLEPGO -// RUN: %clang_cc1 -O2 -fprofil

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

sherwin-dc added a comment. @tejohnson would you be able to take another look at this again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109234/new/ https://reviews.llvm.org/D109234 ___ cfe-commits mail

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

sherwin-dc updated this revision to Diff 371315. sherwin-dc added a comment. - Consolidate test cases into one Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109234/new/ https://reviews.llvm.org/D109234 Files: clang/test/CodeGen/pgo-sample-thinlt

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

sherwin-dc marked 2 inline comments as done. sherwin-dc added inline comments. Comment at: clang/test/CodeGen/pgo-sample-thinlto-summary.c:1 -// RUN: %clang_cc1 -O2 -fprofile-sample-use=%S/Inputs/pgo-sample-thinlto-summary.prof %s -emit-llvm -o - 2>&1 | FileCheck %s -check-pref

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

tejohnson added inline comments. Comment at: clang/test/CodeGen/pgo-sample-thinlto-summary.c:1 -// RUN: %clang_cc1 -O2 -fprofile-sample-use=%S/Inputs/pgo-sample-thinlto-summary.prof %s -emit-llvm -o - 2>&1 | FileCheck %s -check-prefix=SAMPLEPGO -// RUN: %clang_cc1 -O2 -fprofil

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

sherwin-dc updated this revision to Diff 371040. sherwin-dc added a comment. [PGO] Change tests to look at passes run Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109234/new/ https://reviews.llvm.org/D109234 Files: clang/test/CodeGen/pgo-sample

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

sherwin-dc added a comment. I have changed the unroll and icp tests to instead look at the passes that were run, which are shown with the `-mllvm -opt-bisect-limit=-1` flag. This should allow checking that the Loop Unrolling and Indirect Call Promotion passes are run with samplepgo but not thin

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

sherwin-dc updated this revision to Diff 371036. sherwin-dc edited the summary of this revision. sherwin-dc added a comment. [PGO] Change tests to look at which passes were run Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109234/new/ https://revie

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

sherwin-dc added inline comments. Comment at: clang/test/CodeGen/pgo-sample-thinlto-summary.c:25 // Checks if loop unroll is invoked by normal compile, but not thinlto compile. // SAMPLEPGO-LABEL: define {{(dso_local )?}}void @unroll tejohnson wrote: > It see

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

tejohnson added inline comments. Comment at: clang/test/CodeGen/pgo-sample-thinlto-summary.c:25 // Checks if loop unroll is invoked by normal compile, but not thinlto compile. // SAMPLEPGO-LABEL: define {{(dso_local )?}}void @unroll It seems this test is expl