[PATCH] D109175: [openmp] Emit deferred diag only when device compilation presents

2021-10-25 Thread Wei Wang via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGb283d55c90dd: [openmp] Emit deferred diag only when device compilation presents (authored by weiwang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109175/n

[PATCH] D109175: [openmp] Emit deferred diag only when device compilation presents

2021-09-15 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109175/new/ https://reviews.llvm.org/D109175 _

[PATCH] D109175: [openmp] Emit deferred diag only when device compilation presents

2021-09-15 Thread Wei Wang via Phabricator via cfe-commits
weiwang added a comment. In D109175#2989997 , @yaxunl wrote: > In D109175#2989823 , @weiwang wrote: > >> In D109175#2987048 , @jdoerfert >> wrote: >> >>> In D109175#29867

[PATCH] D109175: [openmp] Emit deferred diag only when device compilation presents

2021-09-08 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. In D109175#2989823 , @weiwang wrote: > In D109175#2987048 , @jdoerfert > wrote: > >> In D109175#2986782 , @yaxunl wrote: >> >>> I agree with Johan

[PATCH] D109175: [openmp] Emit deferred diag only when device compilation presents

2021-09-08 Thread Wei Wang via Phabricator via cfe-commits
weiwang added a comment. In D109175#2987048 , @jdoerfert wrote: > In D109175#2986782 , @yaxunl wrote: > >> I agree with Johannes and Alexey that deferred diags are only needed when >> LangOpts.OMPTargetTriples.em

[PATCH] D109175: [openmp] Emit deferred diag only when device compilation presents

2021-09-07 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. In D109175#2986782 , @yaxunl wrote: > I agree with Johannes and Alexey that deferred diags are only needed when > LangOpts.OMPTargetTriples.empty(). However, I am not sure whether it is only > needed in device compilation. > >

[PATCH] D109175: [openmp] Emit deferred diag only when device compilation presents

2021-09-07 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. I agree with Johannes and Alexey that deferred diags are only needed when LangOpts.OMPTargetTriples.empty(). However, I am not sure whether it is only needed in device compilation. For other offloading languages like CUDA/HIP it is needed in both device and host compila