[PATCH] D109167: Try to unbreak Win build differently after 973519826edb76

mehdi_amini added a comment. > @goncharov @mehdi_amini is there a way to change the way the phab UI or the > pre-merge checks work here to make failing pre-merge checks clearer? This > isn't the first time I've seen someone be very confused about this UI I asked the same thing a few days ago an

[PATCH] D109167: Try to unbreak Win build differently after 973519826edb76

thakis added a comment. In D109167#2980604 , @GMNGeoffrey wrote: >> I had fixed this in >> https://github.com/llvm/llvm-project/commit/9d227543890e721b95303430ee1427ce5aa7292f >> . Precommit bot on this change was green though as far as I can tell. > >

[PATCH] D109167: Try to unbreak Win build differently after 973519826edb76

GMNGeoffrey added subscribers: goncharov, mehdi_amini. GMNGeoffrey added a comment. In D109167#2980604 , @GMNGeoffrey wrote: >> I had fixed this in >> https://github.com/llvm/llvm-project/commit/9d227543890e721b95303430ee1427ce5aa7292f >> . Precommit b

[PATCH] D109167: Try to unbreak Win build differently after 973519826edb76

GMNGeoffrey added a comment. > I had fixed this in > https://github.com/llvm/llvm-project/commit/9d227543890e721b95303430ee1427ce5aa7292f > . Precommit bot on this change was green though as far as I can tell. Harbormaster comments with a green check mark that build has completed, but if you l

[PATCH] D109167: Try to unbreak Win build differently after 973519826edb76

thakis added a comment. In D109167#2980560 , @GMNGeoffrey wrote: > I'm seeing a build failure coming out of this: > >> llvm-project/lld/wasm/Writer.cpp:521:16: error: non-const lvalue reference >> to type 'llvm::StringRef' cannot bind to a temporary of

[PATCH] D109167: Try to unbreak Win build differently after 973519826edb76

GMNGeoffrey added a comment. I'm seeing a build failure coming out of this: > llvm-project/lld/wasm/Writer.cpp:521:16: error: non-const lvalue reference to > type 'llvm::StringRef' cannot bind to a temporary of type 'llvm::StringRef' > > for (auto &feature : used.keys()) { Looks like pre-merg

[PATCH] D109167: Try to unbreak Win build differently after 973519826edb76

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5881dcff7e76: Try to unbreak Win build differently after 973519826edb76 (authored by thakis). Herald added a project: clang. Herald added a subscribe