[PATCH] D109158: [clang][deps] Test diagnostic options are being respected

2021-09-10 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 added a comment. In D109158#2995095 , @supergrecko wrote: > Hi, are these test cases supposed to be under /llvm in the monorepo? Right > now they are at a new path, /llvm/clang/test/... which doesn't look right. You're right, thanks. Fixed

[PATCH] D109158: [clang][deps] Test diagnostic options are being respected

2021-09-10 Thread Mats Larsen via Phabricator via cfe-commits
supergrecko added a comment. Hi, are these test cases supposed to be under /llvm in the monorepo? Right now they are at a new path, /llvm/clang/test/... which doesn't look right. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109158/new/ https://re

[PATCH] D109158: [clang][deps] Test diagnostic options are being respected

2021-09-10 Thread Jan Svoboda via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7afabc2e4e86: [clang][deps] Test diagnostic options are being respected (authored by jansvoboda11). Herald added a project: LLVM. Herald added a subs

[PATCH] D109158: [clang][deps] Test diagnostic options are being respected

2021-09-02 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. The test LGTM. I'd prefer you to squash this into https://reviews.llvm.org/D108974 though, since it seems to contain the necessary bits to make the test pass. Repository: rG LLVM G

[PATCH] D109158: [clang][deps] Test diagnostic options are being respected

2021-09-02 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, arphaman. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch tests code in D108976 . This split