[PATCH] D109078: [clang][driver][AIX] Add system libc++ header paths to driver

This revision was automatically updated to reflect the committed changes. Closed by commit rG1f3925e25ae0: [clang][driver][AIX] Add system libc++ header paths to driver (authored by daltenty). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109078/new/

[PATCH] D109078: [clang][driver][AIX] Add system libc++ header paths to driver

ZarkoCA accepted this revision. ZarkoCA added a comment. This revision is now accepted and ready to land. Thanks, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109078/new/ https://reviews.llvm.org/D109078

[PATCH] D109078: [clang][driver][AIX] Add system libc++ header paths to driver

daltenty updated this revision to Diff 372570. daltenty added a comment. - Fix additional test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109078/new/ https://reviews.llvm.org/D109078 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/li

[PATCH] D109078: [clang][driver][AIX] Add system libc++ header paths to driver

daltenty updated this revision to Diff 372566. daltenty added a comment. - Update check patttern to allow windows directory seperators Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109078/new/ https://reviews.llvm.org/D109078 Files: clang/lib/Dr

[PATCH] D109078: [clang][driver][AIX] Add system libc++ header paths to driver

daltenty added inline comments. Comment at: clang/test/Driver/aix-toolchain-include.cpp:31 +// CHECK-INTERNAL-INCLUDE: "-isysroot" "[[SYSROOT:[^"]+]]" +// CHECK-INTERNAL-INCLUDE-CXX: "-internal-isystem" "[[SYSROOT]]/opt/IBM/openxlCSDK/include/c++/v1" +// CHECK-INTERNAL-INC

[PATCH] D109078: [clang][driver][AIX] Add system libc++ header paths to driver

ZarkoCA added inline comments. Comment at: clang/test/Driver/aix-toolchain-include.cpp:31 +// CHECK-INTERNAL-INCLUDE: "-isysroot" "[[SYSROOT:[^"]+]]" +// CHECK-INTERNAL-INCLUDE-CXX: "-internal-isystem" "[[SYSROOT]]/opt/IBM/openxlCSDK/include/c++/v1" +// CHECK-INTERNAL-INCL

[PATCH] D109078: [clang][driver][AIX] Add system libc++ header paths to driver

daltenty updated this revision to Diff 371078. daltenty added a comment. - Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109078/new/ https://reviews.llvm.org/D109078 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/lib/

[PATCH] D109078: [clang][driver][AIX] Add system libc++ header paths to driver

daltenty added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:240-242 + case ToolChain::CST_Libstdcxx: +llvm::report_fatal_error( +"picking up libstdc++ headers is unimplemented on AIX"); ZarkoCA wrote: > nit: it would be my prefere

[PATCH] D109078: [clang][driver][AIX] Add system libc++ header paths to driver

ZarkoCA added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:237 +addSystemInclude(DriverArgs, CC1Args, PathCPP.str()); +CC1Args.push_back("-D__LIBC_NO_CPP_MATH_OVERLOADS__"); +return; Maybe a comment as to why we need this, somethin

[PATCH] D109078: [clang][driver][AIX] Add system libc++ header paths to driver

daltenty created this revision. daltenty added reviewers: hubert.reinterpretcast, stevewan, ZarkoCA. daltenty requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change adds the system libc++ header location to the driver. As well we defi