[PATCH] D109057: [openmp] Accept directory for libomptarget-bc-path

JonChesterfield added a comment. Nice, thanks! I'll wait for the main CI to come back up before trying that Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109057/new/ https://reviews.llvm.org/D109057 ___

[PATCH] D109057: [openmp] Accept directory for libomptarget-bc-path

Meinersbur added inline comments. Comment at: clang/test/Driver/openmp-offload-gpu.c:178 // CHK-BCLIB-USER: clang{{.*}}-triple{{.*}}nvptx64-nvidia-cuda{{.*}}-mlink-builtin-bitcode{{.*}}libomptarget-nvptx-test.bc - +// CHK-BCLIB-USER-DIR: clang{{.*}}-triple{{.*}}nvptx64-nvidia-

[PATCH] D109057: [openmp] Accept directory for libomptarget-bc-path

jdoerfert added a subscriber: Meinersbur. jdoerfert added a comment. In D109057#2977859 , @JonChesterfield wrote: > Turns out {{.}} is also fine as far as Linux is concerned and unacceptable to > Windows. I can't run anything on Windows locally, and tri

[PATCH] D109057: [openmp] Accept directory for libomptarget-bc-path

JonChesterfield added a comment. Turns out {{.}} is also fine as far as Linux is concerned and unacceptable to Windows. I can't run anything on Windows locally, and trial and error while watching http://45.33.8.238/win has taken too many iterations already, so I've dropped the test case in 06cd

[PATCH] D109057: [openmp] Accept directory for libomptarget-bc-path

This revision was automatically updated to reflect the committed changes. Closed by commit rGc7cbf1a03ea6: [openmp] Accept directory for libomptarget-bc-path (authored by JonChesterfield). Changed prior to commit: https://reviews.llvm.org/D109057?vs=370006&id=370040#toc Repository: rG LLVM G

[PATCH] D109057: [openmp] Accept directory for libomptarget-bc-path

JonChesterfield added a comment. Bad times. Changing that to accept the / was a shotgun fix for the problem but it collides with one of the nearby regex, reverting while I work out what is going on Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109

[PATCH] D109057: [openmp] Accept directory for libomptarget-bc-path

JonChesterfield added a comment. In D109057#2977632 , @thakis wrote: > This breaks tests on windows: http://45.33.8.238/win/44930/step_7.txt > > Please take a look and revert if it takes a while to fix. Probably just need > to optionally accept win slash

[PATCH] D109057: [openmp] Accept directory for libomptarget-bc-path

thakis added a comment. This breaks tests on windows: http://45.33.8.238/win/44930/step_7.txt Please take a look and revert if it takes a while to fix. Probably just need to optionally accept win slashiness in the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D109057: [openmp] Accept directory for libomptarget-bc-path

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0173e024fd9e: [openmp] Accept directory for libomptarget-bc-path (authored by JonChesterfield). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D109057: [openmp] Accept directory for libomptarget-bc-path

JonChesterfield added a comment. OK, test added, same code as originally, checked that the test fails on trunk. Because it's driver only we don't get a far as the fatal error, but you can see the driver passing the directory through to builtin-bitcode. Will land when the premerge checks catch u

[PATCH] D109057: [openmp] Accept directory for libomptarget-bc-path

JonChesterfield updated this revision to Diff 369972. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109057/new/ https://reviews.llvm.org/D109057 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/test/Driver/openmp-offload-gpu.c Index: cl

[PATCH] D109057: [openmp] Accept directory for libomptarget-bc-path

JonChesterfield updated this revision to Diff 369971. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109057/new/ https://reviews.llvm.org/D109057 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/test/Driver/openmp-offload-gpu.c Index: cl

[PATCH] D109057: [openmp] Accept directory for libomptarget-bc-path

JonChesterfield added a comment. Well, that's not helpful. Managed to add a test through the webui as arcanist was misbehaving but it has worked by deleting the functional change. Will try again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109057

[PATCH] D109057: [openmp] Accept directory for libomptarget-bc-path

JonChesterfield updated this revision to Diff 369969. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109057/new/ https://reviews.llvm.org/D109057 Files: clang/test/Driver/openmp-offload-gpu.c Index: clang/test/Driver/openmp-offload-gpu.c

[PATCH] D109057: [openmp] Accept directory for libomptarget-bc-path

JonChesterfield added a comment. In D109057#2977084 , @jdoerfert wrote: > LG, but please add a test for this. D109061 sends everything in check-openmp down this code path, but we should indeed have a check for the file

[PATCH] D109057: [openmp] Accept directory for libomptarget-bc-path

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, but please add a test for this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109057/new/ https://reviews.llvm.org/D109057 __

[PATCH] D109057: [openmp] Accept directory for libomptarget-bc-path

JonChesterfield created this revision. JonChesterfield added reviewers: tianshilei1992, grokos, jdoerfert. Herald added subscribers: guansong, yaxunl. JonChesterfield requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. The commandline