jansvoboda11 added inline comments.
Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2270-2274
+ if (UseNewCC1Process)
+*UseNewCC1Process =
+Args.hasFlag(clang::driver::options::OPT_fno_integrated_cc1,
+ clang::driver::options::OPT_fintegrate
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG555a817d1dac: [clang] NFC: Extract DiagnosticOptions parsing
(authored by jansvoboda11).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST A
jansvoboda11 updated this revision to Diff 370238.
jansvoboda11 added a comment.
Switch to unique_ptr, leave -fno-intergrated-cc1 behind.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108918/new/
https://reviews.llvm.org/D108918
Files:
clang/inc
dexonsmith accepted this revision.
dexonsmith added a comment.
This revision is now accepted and ready to land.
A few comments inline, but LGTM once you fix those.
Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2259-2260
+DiagnosticOptions *clang::CreateAndPopulateDiag
jansvoboda11 created this revision.
jansvoboda11 added reviewers: Bigcheese, dexonsmith, arphaman.
jansvoboda11 requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
The way we parse `DiagnosticOptions` is a bit involved.
`DiagnosticOptions` are
