[PATCH] D108794: Fully qualify template template parameters when printing

2021-09-02 Thread David Blaikie via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. dblaikie marked an inline comment as done. Closed by commit rG5fb3f43778f8: Fully qualify template template parameters when printing (authored by dblaikie). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D108794: Fully qualify template template parameters when printing

2021-09-02 Thread Richard Trieu via Phabricator via cfe-commits
rtrieu accepted this revision. rtrieu added a comment. This revision is now accepted and ready to land. In D108794#2978134 , @dblaikie wrote: > Ping > > In D108794#2976063 , @rtrieu wrote: > >> It looks like a str

[PATCH] D108794: Fully qualify template template parameters when printing

2021-09-01 Thread David Blaikie via Phabricator via cfe-commits
dblaikie marked an inline comment as done. dblaikie added a comment. Ping In D108794#2976063 , @rtrieu wrote: > It looks like a strict improvement on printing and most callers using the > default args won't need to be updated. > > There's one more funct

[PATCH] D108794: Fully qualify template template parameters when printing

2021-09-01 Thread David Blaikie via Phabricator via cfe-commits
dblaikie updated this revision to Diff 370086. dblaikie added a comment. Herald added subscribers: usaxena95, kadircet. Herald added a project: clang-tools-extra. Fix the clang-tools-extra caller, and update the TemplateName::print doc comment Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D108794: Fully qualify template template parameters when printing

2021-08-31 Thread Richard Trieu via Phabricator via cfe-commits
rtrieu added a comment. It looks like a strict improvement on printing and most callers using the default args won't need to be updated. There's one more function call that should be updated: https://github.com/llvm/llvm-project/blob/main/clang-tools-extra/clangd/DumpAST.cpp#L298 Fixing that an

[PATCH] D108794: Fully qualify template template parameters when printing

2021-08-26 Thread David Blaikie via Phabricator via cfe-commits
dblaikie created this revision. dblaikie added reviewers: aaron.ballman, rtrieu. Herald added a subscriber: arphaman. dblaikie requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I discovered this quirk when working on some DWARF - AST printing