[PATCH] D108787: [CUDA] Pass ExecConfig through BuildCallToMemberFunction

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6b20ea696356: [CUDA] Pass ExecConfig through BuildCallToMemberFunction (authored by tra). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D108787: [CUDA] Pass ExecConfig through BuildCallToMemberFunction

yaxunl accepted this revision. yaxunl added a comment. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108787/new/ https://reviews.llvm.org/D108787 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D108787: [CUDA] Pass ExecConfig through BuildCallToMemberFunction

tra added a comment. In D108787#243 , @yaxunl wrote: > I am concerned that there may be more places which need handling, and passing > exec config expr by function arguments may not scale. > Is it possible to represent the kernel call expr by a deri

[PATCH] D108787: [CUDA] Pass ExecConfig through BuildCallToMemberFunction

yaxunl added a comment. I am concerned that there may be more places which need handling, and passing exec config expr by function arguments may not scale. Is it possible to represent the kernel call expr by a derived class of call expr and add the exec config expr as member to it? Repository

[PATCH] D108787: [CUDA] Pass ExecConfig through BuildCallToMemberFunction

tra added a comment. In D108787#2968503 , @yaxunl wrote: > need a test for non-template static member function as kernel. also need > codegen tests. I've added more tests for different code paths leading to the kernel call. Interestingly enough, only t

[PATCH] D108787: [CUDA] Pass ExecConfig through BuildCallToMemberFunction

tra updated this revision to Diff 369140. tra edited the summary of this revision. tra added a comment. Added more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108787/new/ https://reviews.llvm.org/D108787 Files: clang/include/clang/Sema/S

[PATCH] D108787: [CUDA] Pass ExecConfig through BuildCallToMemberFunction

yaxunl added a comment. need a test for non-template static member function as kernel. also need codegen tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108787/new/ https://reviews.llvm.org/D108787 ___

[PATCH] D108787: [CUDA] Pass ExecConfig through BuildCallToMemberFunction

jlebar accepted this revision. jlebar added a comment. This revision is now accepted and ready to land. Thanks, Art. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108787/new/ https://reviews.llvm.org/D108787 ___

[PATCH] D108787: [CUDA] Pass ExecConfig through BuildCallToMemberFunction

tra created this revision. tra added reviewers: jlebar, yaxunl. Herald added subscribers: bixia, inglorion. tra requested review of this revision. Herald added a project: clang. Otherwise, we fail to compile calls to CUDA kernels that are static members. Repository: rG LLVM Github Monorepo ht