[PATCH] D108752: [clang-format] Group options that pack constructor initializers

owenpan marked an inline comment as done. owenpan added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:18472 + FormatStyle::PCIS_Never); + Style.EmptyLineBeforeAccessModifier = FormatStyle::ELBAMS_LogicalBlock; owenpan wrote: >

[PATCH] D108752: [clang-format] Group options that pack constructor initializers

This revision was automatically updated to reflect the committed changes. Closed by commit rG8a780a2f18c5: [clang-format] Group options that pack constructor initializers (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108752/new

[PATCH] D108752: [clang-format] Group options that pack constructor initializers

owenpan added a comment. In D108752#2967040 , @MyDeveloperDay wrote: > This looks good, I like to move towards one style, it was getting too > confusing. I agree! > Did you test this on a large code base at all? No. I don't think it's necessary (as t

[PATCH] D108752: [clang-format] Group options that pack constructor initializers

owenpan updated this revision to Diff 369061. owenpan added a comment. Added backward compatibility for the default value `PCIS_NextLine` in Google and Chromium styles and aforementioned cleanups. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108752/new/ https://reviews.llvm.org/D10875

[PATCH] D108752: [clang-format] Group options that pack constructor initializers

owenpan added inline comments. Comment at: clang/lib/Format/Format.cpp:1189 GoogleStyle.DerivePointerAlignment = true; + GoogleStyle.PackConstructorInitializers = FormatStyle::PCIS_NextLine; GoogleStyle.IncludeStyle.IncludeCategories = {{"^", 2, 0, false},

[PATCH] D108752: [clang-format] Group options that pack constructor initializers

owenpan added inline comments. Comment at: clang/lib/Format/Format.cpp:666-677 +if (Style.PackConstructorInitializers == FormatStyle::PCIS_BinPack) { + bool OnCurrentLine = false; + IO.mapOptional("ConstructorInitializerAllOnOneLineOrOnePerLine", +

[PATCH] D108752: [clang-format] Group options that pack constructor initializers

owenpan added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:18472 + FormatStyle::PCIS_Never); + Style.EmptyLineBeforeAccessModifier = FormatStyle::ELBAMS_LogicalBlock; HazardyKnusperkeks wrote: > Should there be a test for the

[PATCH] D108752: [clang-format] Group options that pack constructor initializers

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:18472 + FormatStyle::PCIS_Never); + Style.EmptyLineBeforeAccessModifier = FormatStyle::ELBAMS_LogicalBlock; Shou

[PATCH] D108752: [clang-format] Group options that pack constructor initializers

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. This looks good, I like to move towards one style, it was getting too confusing. Did you test this on a large code base at all? and maybe wait for one of the others to take a l

[PATCH] D108752: [clang-format] Group options that pack constructor initializers

owenpan created this revision. owenpan added reviewers: djasper, klimek, krasimir, MyDeveloperDay, curdeius, HazardyKnusperkeks. owenpan added a project: clang-format. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add a new optio