This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG78f92c38101f: [openmp][amdgpu] Initial gfx10 offloading
implementation (authored by JonChesterfield).
Repository:
rG LLVM Github Monorepo
CHANGES
ronlieb accepted this revision.
ronlieb added a comment.
This revision is now accepted and ready to land.
since amdgpu buildbots are red, at Jon's request, i applied patch on latest
trunk build.
applies clean, builds fine, no additional regressions in bheck-openmp
compiler now accepts -march=gfx
JonChesterfield added inline comments.
Comment at: openmp/libomptarget/plugins/amdgpu/src/rtl.cpp:1921
DP("Max_Teams: %d\n", Max_Teams);
-DP("RTLDeviceInfoTy::Warp_Size: %d\n", RTLDeviceInfoTy::Warp_Size);
+DP("RTLDeviceInfoTy::Warp_Size: %d\n", WarpSize);
DP("R
JonChesterfield marked an inline comment as done.
JonChesterfield added a subscriber: dhruvachak.
JonChesterfield added inline comments.
Comment at: openmp/libomptarget/deviceRTLs/amdgcn/CMakeLists.txt:111
+set(mcpus gfx700 gfx701 gfx801 gfx803 gfx900 gfx902 gfx906 gfx908 gfx1010
JonChesterfield updated this revision to Diff 369069.
JonChesterfield added a comment.
- add 1030
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108708/new/
https://reviews.llvm.org/D108708
Files:
clang/lib/Basic/Targets/AMDGPU.h
llvm/include/l
JonChesterfield updated this revision to Diff 369067.
JonChesterfield added a comment.
- uint32 to unsigned
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108708/new/
https://reviews.llvm.org/D108708
Files:
clang/lib/Basic/Targets/AMDGPU.h
llvm
ronlieb added inline comments.
Comment at: openmp/libomptarget/deviceRTLs/amdgcn/CMakeLists.txt:111
+set(mcpus gfx700 gfx701 gfx801 gfx803 gfx900 gfx902 gfx906 gfx908 gfx1010
gfx1031)
if (DEFINED LIBOMPTARGET_AMDGCN_GFXLIST)
set(mcpus ${LIBOMPTARGET_AMDGCN_GFXLIST})
JonChesterfield added inline comments.
Comment at: llvm/include/llvm/Frontend/OpenMP/OMPGridValues.h:102
+
+template constexpr const GV &getAMDGPUGridValues() {
+ static_assert(wavesize == 32 || wavesize == 64, "");
Want to resolve this at compile time for the
JonChesterfield created this revision.
JonChesterfield added reviewers: dpalermo, jdoerfert, tianshilei1992, ronlieb,
ye-luo, grokos.
Herald added subscribers: kerbowa, guansong, t-tye, tpr, dstuttard, yaxunl,
mgorny, nhaehnle, jvesely, kzhuravl.
JonChesterfield requested review of this revision.
