[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

linjamaki added a comment. Thanks, @Anastasia. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108621/new/ https://reviews.llvm.org/D108621 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

This revision was automatically updated to reflect the committed changes. Closed by commit rGf4d3cb4ca833: [HIPSPV] Add CUDA->SPIR-V address space mapping (authored by Anastasia). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108621/new/ https://rev

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

linjamaki added a comment. @Anastasia, Could you please commit this patch to the LLVM for us? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108621/new/ https://reviews.llvm.org/D108621 ___ cfe-co

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108621/new/ https://reviews.llvm.org/D108621 _

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

linjamaki added inline comments. Comment at: clang/lib/Basic/Targets/SPIR.h:233 +if (Opts.HIP && Opts.CUDAIsDevice) + // Enable address space mapping from HIP to SPIR-V. + // See comment on the SPIRDefIsGenMap table. Anastasia wrote: > linjamaki wro

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

linjamaki updated this revision to Diff 387500. linjamaki added a comment. Rebase, add asserts and move address space map reset for HIP from SPIRVTargetInfo to BaseSPIRTargetInfo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108621/new/ https://re

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

Anastasia added inline comments. Comment at: clang/lib/Basic/Targets/SPIR.h:233 +if (Opts.HIP && Opts.CUDAIsDevice) + // Enable address space mapping from HIP to SPIR-V. + // See comment on the SPIRDefIsGenMap table. linjamaki wrote: > Anastasia wro

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

linjamaki added a comment. Gentle ping. Is anything needed to be addressed to get this patch accepted? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108621/new/ https://reviews.llvm.org/D108621 ___ cfe-c

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

linjamaki updated this revision to Diff 381850. linjamaki added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108621/new/ https://reviews.llvm.org/D108621 Files: clang/lib/Basic/Targets/SPIR.h clang/test/CodeGenHIP/hipspv-ad

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

Anastasia added inline comments. Comment at: clang/lib/Basic/Targets/SPIR.h:59 +// translation). This mapping is enabled when the language mode is HIP. +1, // cuda_device +// cuda_constant pointer can be casted to default/"flat" pointer, but in bader

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

bader added inline comments. Comment at: clang/lib/Basic/Targets/SPIR.h:59 +// translation). This mapping is enabled when the language mode is HIP. +1, // cuda_device +// cuda_constant pointer can be casted to default/"flat" pointer, but in Anastasia

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

Anastasia added inline comments. Comment at: clang/lib/Basic/Targets/SPIR.h:59 +// translation). This mapping is enabled when the language mode is HIP. +1, // cuda_device +// cuda_constant pointer can be casted to default/"flat" pointer, but in bader

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

bader added inline comments. Comment at: clang/lib/Basic/Targets/SPIR.h:59 +// translation). This mapping is enabled when the language mode is HIP. +1, // cuda_device +// cuda_constant pointer can be casted to default/"flat" pointer, but in Anastasia

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

linjamaki updated this revision to Diff 375221. linjamaki added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108621/new/ https://reviews.llvm.org/D108621 Files: clang/lib/Basic/Targets/SPIR.h clang/test/CodeGenHIP/hipspv-ad

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

linjamaki updated this revision to Diff 375219. linjamaki added a comment. Herald added subscribers: llvm-commits, dexonsmith, hiraditya. Herald added a project: LLVM. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108621/new/ https://review

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

Anastasia added inline comments. Comment at: clang/lib/Basic/Targets/SPIR.h:59 +// translation). This mapping is enabled when the language mode is HIP. +1, // cuda_device +// cuda_constant pointer can be casted to default/"flat" pointer, but in bader

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

bader added inline comments. Comment at: clang/lib/Basic/Targets/SPIR.h:59 +// translation). This mapping is enabled when the language mode is HIP. +1, // cuda_device +// cuda_constant pointer can be casted to default/"flat" pointer, but in Anastasia

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

Anastasia added inline comments. Comment at: clang/lib/Basic/Targets/SPIR.h:59 +// translation). This mapping is enabled when the language mode is HIP. +1, // cuda_device +// cuda_constant pointer can be casted to default/"flat" pointer, but in linjam

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

linjamaki updated this revision to Diff 373497. linjamaki edited the summary of this revision. linjamaki added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108621/new/ https://reviews.llvm.org/D108621 Files: clang/lib/Basic/T

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

linjamaki marked an inline comment as done. linjamaki added inline comments. Comment at: clang/lib/Basic/Targets/SPIR.h:59 +// translation). This mapping is enabled when the language mode is HIP. +1, // cuda_device +// cuda_constant pointer can be casted to default/"f

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

linjamaki added inline comments. Comment at: clang/lib/Basic/Targets/SPIR.h:233 +if (Opts.HIP && Opts.CUDAIsDevice) + // Enable address space mapping from HIP to SPIR-V. + // See comment on the SPIRDefIsGenMap table. Anastasia wrote: > My guess is t

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

bader added inline comments. Comment at: clang/lib/Basic/Targets/SPIR.h:59 +// translation). This mapping is enabled when the language mode is HIP. +1, // cuda_device +// cuda_constant pointer can be casted to default/"flat" pointer, but in keryell wr

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

keryell added inline comments. Comment at: clang/lib/Basic/Targets/SPIR.h:59 +// translation). This mapping is enabled when the language mode is HIP. +1, // cuda_device +// cuda_constant pointer can be casted to default/"flat" pointer, but in Anastasi

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

Anastasia added inline comments. Comment at: clang/lib/Basic/Targets/SPIR.h:233 +if (Opts.HIP && Opts.CUDAIsDevice) + // Enable address space mapping from HIP to SPIR-V. + // See comment on the SPIRDefIsGenMap table. My guess is that this is not onl

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

Anastasia added inline comments. Comment at: clang/lib/Basic/Targets/SPIR.h:59 +// translation). This mapping is enabled when the language mode is HIP. +1, // cuda_device +// cuda_constant pointer can be casted to default/"flat" pointer, but in bader

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

linjamaki updated this revision to Diff 371877. linjamaki added a comment. Enable HIP-to-SPIR-V address space mapping only for SPIR-V targets. Patch now depends on D109144 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

bader added inline comments. Comment at: clang/lib/Basic/Targets/SPIR.h:59 +// translation). This mapping is enabled when the language mode is HIP. +1, // cuda_device +// cuda_constant pointer can be casted to default/"flat" pointer, but in Anastasia

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

linjamaki planned changes to this revision. linjamaki added a comment. Thanks. I will make a patch for adding spirv triples and new target info and update this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108621/new/ https://reviews.llvm.org/D10

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

Anastasia added inline comments. Comment at: clang/lib/Basic/Targets/SPIR.h:59 +// translation). This mapping is enabled when the language mode is HIP. +1, // cuda_device +// cuda_constant pointer can be casted to default/"flat" pointer, but in I am s

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

bader accepted this revision. bader added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/lib/Basic/Targets/SPIR.h:146 +// See comment on the SPIRDefIsGenMap table. +bool IsHIPSPV = Opts.HIP && Opts.CUDAIsDevice; // FIXME: SYCL s

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

linjamaki created this revision. Herald added a subscriber: yaxunl. linjamaki requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add mapping for CUDA address spaces for HIP to SPIR-V translation. This change allows HIP device code to be emitte