[PATCH] D108555: [tsan] Make sanitize-thread-disable.c an X86-only test

glider added a comment. In D108555#2960034 , @melver wrote: > LGTM, thanks! > > Patch title ("...an X86-only test..") also needs adjustment. It's strange that Phab doesn't automatically update the title when I update the commit message. Repository:

[PATCH] D108555: [tsan] Make sanitize-thread-disable.c an X86-only test

melver accepted this revision. melver added a comment. This revision is now accepted and ready to land. LGTM, thanks! Patch title ("...an X86-only test..") also needs adjustment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108555/new/ https://re

[PATCH] D108555: [tsan] Make sanitize-thread-disable.c an X86-only test

glider added inline comments. Comment at: clang/test/CodeGen/X86/sanitize-thread-disable.c:22 int instrumented1(int *a, _Atomic int *b) { return *a + atomic_load(b); } melver wrote: > melver wrote: > > I think you do not need to use atomic_load. > > > > You

[PATCH] D108555: [tsan] Make sanitize-thread-disable.c an X86-only test

glider updated this revision to Diff 368096. glider added a comment. Removed the header Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108555/new/ https://reviews.llvm.org/D108555 Files: clang/test/CodeGen/sanitize-thread-disable.c Index: clang

[PATCH] D108555: [tsan] Make sanitize-thread-disable.c an X86-only test

melver added inline comments. Comment at: clang/test/CodeGen/X86/sanitize-thread-disable.c:22 int instrumented1(int *a, _Atomic int *b) { return *a + atomic_load(b); } melver wrote: > I think you do not need to use atomic_load. > > You can just deref b, and

[PATCH] D108555: [tsan] Make sanitize-thread-disable.c an X86-only test

melver added inline comments. Comment at: clang/test/CodeGen/X86/sanitize-thread-disable.c:22 int instrumented1(int *a, _Atomic int *b) { return *a + atomic_load(b); } I think you do not need to use atomic_load. You can just deref b, and because it's _Atomi

[PATCH] D108555: [tsan] Make sanitize-thread-disable.c an X86-only test

glider added a comment. Not really sure what's the best solution here, but I think restricting the test to x86 should help. So far only ARM and PPC bots reported failures. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108555/new/ https://reviews.l

[PATCH] D108555: [tsan] Make sanitize-thread-disable.c an X86-only test

glider created this revision. glider added a reviewer: melver. Herald added subscribers: pengfei, jfb, kristof.beyls. glider requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Looks like non-x86 bots are unhappy with inclusion of e.g.: clang